Skip to content

Commit

Permalink
fix: plugin-driver using threads cannot read if file logging enabled
Browse files Browse the repository at this point in the history
affects windows - see pact-foundation/pact-plugins#69
  • Loading branch information
YOU54F committed Aug 19, 2024
1 parent 6a7a896 commit 333f548
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions modules/plugin/src/main/resources/logback.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,13 @@
</encoder>
</appender>

<appender name="PLAIN_FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
<!-- <appender name="PLAIN_FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
<file>logs/plugin.log</file>
<rollingPolicy class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy">
<!-- daily rollover -->
<fileNamePattern>logs/plugin.%d{yyyy-MM-dd}.%i.log</fileNamePattern>
<timeBasedFileNamingAndTriggeringPolicy class="ch.qos.logback.core.rolling.SizeAndTimeBasedFNATP">
<!-- or whenever the file size reaches 50MB -->
<maxFileSize>50MB</maxFileSize>
</timeBasedFileNamingAndTriggeringPolicy>
<!-- keep 30 days' worth of history -->
<maxHistory>30</maxHistory>
</rollingPolicy>
<encoder>
Expand All @@ -26,11 +23,11 @@
<appender name="PLAIN_ASYNCFILE" class="ch.qos.logback.classic.AsyncAppender">
<appender-ref ref="PLAIN_FILE"/>
<includeCallerData>true</includeCallerData>
</appender>
</appender> -->

<root level="${LOG_LEVEL:-OFF}">
<appender-ref ref="STDOUT" />
<appender-ref ref="PLAIN_ASYNCFILE" />
<!-- <appender-ref ref="PLAIN_ASYNCFILE" /> -->
</root>

<logger name="io.grpc.netty" level="ERROR" />
Expand Down

0 comments on commit 333f548

Please sign in to comment.