DRAW-353 WebSocket 모듈 통신 개편 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunwoongH
reviewed
Sep 18, 2024
Comment on lines
44
to
35
| gameInfo = createGameInfo(roomId, locale, player, true) | ||
| gameInfo = createGameInfo(roomId, locale, player) |
There was a problem hiding this comment.
P1
랜덤 매칭 유저인지 대기방 시작 유저인지 구분되어야 합니다. 이전에 작성할 때 createGameInfo의 isRandomMatching 매개변수로 구분하였는데, 추가적인 로직 수정이 필요해 보입니다.
SunwoongH
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Jira ✔
Description ✔
원래 이벤트 기반으로 하고자 했는데,
게임 시작, 나가기 등은 핵심 액션으로 로직 순서가 중요함.
이를 이벤트 기반으로 느슨하게 만들기보단
명확하게 설정하는 것이 좋아보임
PR Rule ✔
P1: 꼭 반영해주세요 (Request changes)
P2: 적극적으로 고려해주세요 (Request changes)
P3: 웬만하면 반영해 주세요 (Comment)
P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
P5: 그냥 사소한 의견입니다 (Approve)