DRAW-287 MafiaGameInfo 메모리 -> Redis 저장소 이관 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comforest
reviewed
Sep 23, 2024
adapter/redis/src/main/kotlin/com/xorker/draw/config/RedisConfig.kt
Outdated
Show resolved
Hide resolved
...socket/src/main/kotlin/com/xorker/draw/websocket/message/response/MafiaPhaseMessengerImpl.kt
Outdated
Show resolved
Hide resolved
...bsocket/src/main/kotlin/com/xorker/draw/websocket/message/response/MafiaGameMessengerImpl.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # adapter/memory/src/main/kotlin/com/xorker/draw/mafia/MafiaGameAdapter.kt # app/websocket/src/main/kotlin/com/xorker/draw/websocket/broker/SimpleSessionMessageBroker.kt
comforest
approved these changes
Sep 28, 2024
| } | ||
|
|
||
| override fun getTimerStartTime(roomId: RoomId): LocalDateTime { | ||
| val job = jobs[roomId] ?: throw UnSupportedException |
There was a problem hiding this comment.
p4. NotFound Exception 을 만들면 좋을 것 같아요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Jira ✔
Description ✔
PR Rule ✔
P1: 꼭 반영해주세요 (Request changes)
P2: 적극적으로 고려해주세요 (Request changes)
P3: 웬만하면 반영해 주세요 (Comment)
P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
P5: 그냥 사소한 의견입니다 (Approve)