Add focus shortcuts #209
Add focus shortcuts #209
Conversation
|
Instead of disabling this in macos, we need to add a method to |
|
I could try to read the docs and implement the Mac part, but I won't be able to test it as I don't have access to Mac. |
|
It will be enough if you remove those |
The Ctrl+F shortcut gives focus to a search bar in many applications. In this case it allows to search the library without touching a mouse. YACReaderMacOSXSearchLineEdit::setFocus() will have to be implemented to make the shortcut work on macOS.
Focusing the current comics view allows to use keyboard arrow keys to choose among the visible comics. The shortcut for this new action should not be a single character without modifiers because it won't work when the search line has focus. The Qt::FocusReason parameter in ComicsView::focusComicsNavigation() allows to reuse this function for other keyboard navigation features. For instance the search line can transfer focus to comics navigation when the user presses Return or Enter key. In this case Qt::OtherFocusReason can be used (an application-specific reason).
QWidget::sizeHint() is const-qualified, so Clang warns that non-const sizeHint() member functions merely hide the virtual function of the base class. 664dac3 and 9f53ae6 introduced these member functions in 2014 without const qualifiers. QWidget::sizeHint() was const-qualified even in Qt 3. Since these member functions have never had any effect, they should be removed rather than const-qualified to preserve the long-standing behaviors of the two classes. Add a TODO for a similar but less straightforward issue with PropertiesDialog::sizeHint().
vedgy
force-pushed
the
add-focus-shortcuts
branch
2 times, most recently
from
66c5f24 to
288b9cb
Compare
|
The first force-push is a rebase on the current develop. The second force-push contains the actual changes to the previous version, so reviewers can use the second force-pushed link to view the interesting diff. In addition to the requested macOS change, I have removed unused EDIT: GitHub collapsed the two force-pushes into one and left only one force-pushed link - the latest one with the interesting diffs. |
|
Tested on macOS, working as expected. |
|
By the way, I have a WIP branch where pressing Return/Enter transfers focus from the search edit to the comics view. Plus when a folder or a reading list is activated, comics view gets the focus too. In the process of implementing these features I've found numerous Library bugs, most of which are fixed in #219 and the branch mentioned in a comment to #219. |
See the commit messages for details.