Skip to content

Commit

Permalink
Fixed Issues
Browse files Browse the repository at this point in the history
Fixed Issues :
1.) Fixed Comic Downloading That Was Failing Due To New Structure Of Comicpunch.net.

2.) Updated to Xamarin Forms Version 4.2.0.709249.

3.) Added "Startup Tacing" for faster start up in Android Apps. (60% improvement according to Xamarin Forms Docs.)

4.) Re-added advertisements in Android and iOS app (Google Ads.).

5.) Limited search results to return only 10 results at a time for faster searches.
  • Loading branch information
Xonshiz committed Aug 24, 2019
1 parent 262d978 commit a4e431d
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 21 deletions.
14 changes: 6 additions & 8 deletions src/comic_dl/comic_dl.Android/Properties/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,12 @@
<meta-data android:name="com.google.android.gms.version" android:value="@integer/google_play_services_version" />
<activity android:name="com.google.android.gms.ads.AdActivity" android:configChanges="keyboard|keyboardHidden|orientation|screenLayout|uiMode|screenSize|smallestScreenSize" android:theme="@android:style/Theme.Translucent" />
<uses-sdk android:minSdkVersion="21" android:targetSdkVersion="28" />
<application>
<meta-data android:name="com.google.android.gms.ads.APPLICATION_ID" android:value="ca-app-pub-8359860011604747~6496691983" />
</application>
<application>
<meta-data
android:name="com.google.android.gms.ads.AD_MANAGER_APP"
android:value="true"/>
</application>
<application android:label="CoManga" android:icon="@drawable/logo">
<meta-data android:name="com.google.android.gms.ads.APPLICATION_ID" android:value="ca-app-pub-8359860011604747~6496691983" />
</application>
<application>
<meta-data android:name="com.google.android.gms.ads.AD_MANAGER_APP" android:value="true" />
</application>
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
<uses-permission android:name="android.permission.READ_INPUT_STATE" />
<uses-permission android:name="android.permission.PERSISTENT_ACTIVITY" />
Expand Down
4 changes: 4 additions & 0 deletions src/comic_dl/comic_dl.Android/comic_dl.Android.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@
<AndroidUseSharedRuntime>false</AndroidUseSharedRuntime>
<AndroidCreatePackagePerAbi>true</AndroidCreatePackagePerAbi>
<AndroidEnableMultiDex>true</AndroidEnableMultiDex>
<AndroidEnableProfiledAot>false</AndroidEnableProfiledAot>
<AotAssemblies>false</AotAssemblies>
<EnableLLVM>false</EnableLLVM>
<BundleAssemblies>false</BundleAssemblies>
</PropertyGroup>
<ItemGroup>
<Reference Include="Mono.Android" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace comic_dl.Droid.customRenderer
#pragma warning disable CS0618 // Type or member is obsolete
public class AdViewRenderer : ViewRenderer<Controls.AdControlView, AdView>
{
string adUnitId = "ca-app-pub-3940256099942544/6300978111";
string adUnitId = "ca-app-pub-8359860011604747/6645753845";
//Note you may want to adjust this, see further down.
AdSize adSize = AdSize.SmartBanner;
AdView adView;
Expand Down
8 changes: 4 additions & 4 deletions src/comic_dl/comic_dl.UWP/comic_dl.UWP.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="CardsView">
<Version>2.1.7</Version>
<Version>2.2.0</Version>
</PackageReference>
<PackageReference Include="HtmlAgilityPack">
<Version>1.11.12</Version>
Expand All @@ -198,15 +198,15 @@
<Version>12.0.2</Version>
</PackageReference>
<PackageReference Include="Refit">
<Version>4.7.9</Version>
<Version>4.7.51</Version>
</PackageReference>
<PackageReference Include="sqlite-net-pcl">
<Version>1.5.231</Version>
</PackageReference>
<PackageReference Include="Xamarin.Forms" Version="4.1.0.618606" />
<PackageReference Include="Xamarin.Forms" Version="4.2.0.709249" />
<PackageReference Include="Microsoft.NETCore.UniversalWindowsPlatform" Version="6.2.8" />
<PackageReference Include="Xamarin.Forms.Visual.Material">
<Version>4.1.0.618606</Version>
<Version>4.2.0.709249</Version>
</PackageReference>
</ItemGroup>
<ItemGroup>
Expand Down
8 changes: 4 additions & 4 deletions src/comic_dl/comic_dl.iOS/comic_dl.iOS.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,7 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="CardsView">
<Version>2.1.7</Version>
<Version>2.2.0</Version>
</PackageReference>
<PackageReference Include="HtmlAgilityPack">
<Version>1.11.12</Version>
Expand All @@ -628,17 +628,17 @@
<Version>12.0.2</Version>
</PackageReference>
<PackageReference Include="Refit">
<Version>4.7.9</Version>
<Version>4.7.51</Version>
</PackageReference>
<PackageReference Include="sqlite-net-pcl">
<Version>1.5.231</Version>
</PackageReference>
<PackageReference Include="Xamarin.Forms" Version="4.1.0.618606" />
<PackageReference Include="Xamarin.Forms" Version="4.2.0.709249" />
<PackageReference Include="Xamarin.Google.iOS.MobileAds">
<Version>7.38.0</Version>
</PackageReference>
<PackageReference Include="Xamarin.Forms.Visual.Material">
<Version>4.1.0.618606</Version>
<Version>4.2.0.709249</Version>
</PackageReference>
</ItemGroup>
<Import Project="$(MSBuildExtensionsPath)\Xamarin\iOS\Xamarin.iOS.CSharp.targets" />
Expand Down
8 changes: 4 additions & 4 deletions src/comic_dl/comic_dl/comic_dl.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,18 @@
<DebugType>full</DebugType>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="CardsView" Version="2.1.7" />
<PackageReference Include="CardsView" Version="2.2.0" />
<PackageReference Include="HtmlAgilityPack" Version="1.11.12" />
<PackageReference Include="Microsoft.Services.Store.SDK" Version="10.1705.16001" />
<PackageReference Include="Newtonsoft.Json" Version="12.0.2" />
<PackageReference Include="Refit" Version="4.7.9" />
<PackageReference Include="Refit" Version="4.7.51" />
<PackageReference Include="sqlite-net-pcl" Version="1.5.231" />
<PackageReference Include="Xamarin.Forms" Version="4.1.0.618606" />
<PackageReference Include="Xamarin.Forms" Version="4.2.0.709249" />
<PackageReference Include="Xam.Plugins.Forms.ImageCircle" Version="3.0.0.5" />
<PackageReference Include="Plugin.Permissions" Version="3.0.0.12" />
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="2.1.1" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="2.1.1" />
<PackageReference Include="Xamarin.Forms.Visual.Material" Version="4.1.0.618606" />
<PackageReference Include="Xamarin.Forms.Visual.Material" Version="4.2.0.709249" />
</ItemGroup>

<ItemGroup>
Expand Down

0 comments on commit a4e431d

Please sign in to comment.