Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacps: Fix error when multiple PCSPMA IP are instantiated #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@IsaacJT
Copy link

IsaacJT commented Jun 18, 2021

I can confirm that this fixes the compile error but the device tree that comes out isn't quite correct with 2 x PCS/PMA blocks:

&gem0 {
	phy-handle = <&phy7>;
	phy-mode = "gmii";
	status = "okay";
	xlnx,ptp-enet-clock = <0x0>;
};
&gem1 {
	phy-handle = <&phy7>;
	phy-mode = "gmii";
	status = "okay";
	xlnx,ptp-enet-clock = <0x0>;
	phy7: phy@7 {
		reg = <0x07>;
		xlnx,phy-type = <0x5>;
	};
};

It only creates one PHY node and connects both GEMs to the one node. They should each have their own node and appropriate handles.

EDIT: This is easy to fix in the system-user.dtsi but could be a trap for people who aren't aware of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants