Bug fix in patching ctrlpkt-pm symbol #8636
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rbramand <[email protected]>
larry9523
approved these changes
Dec 3, 2024
stsoe
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Fixed a bug while patching ctrlpkt-pm symbol in ELF
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
In PR - #8593 changes were made to patch ctrlpkt-pm symbols, these symbols were stored when ELF is parsed in a vector which created duplicate entries for same symbol when multiple entries of same where present in .rela.dyn section.
How problem was solved, alternative solutions (if any) and why they were rejected
Changed the logic to store the symbols in std::set to avoid duplicate entries.
Risks (if any) associated the changes in the commit
Low
What has been tested and how, request additional testing if necessary
Tested with failing application on strix simnow and patching happens as expected
Documentation impact (if any)
NA