xrtdeps : fix and update Fedora package list #8633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Byvirven - is not a collaborator |
2 similar comments
|
Byvirven - is not a collaborator |
|
Byvirven - is not a collaborator |
Signed-off-by: Marco Dos Santos Oliveira <[email protected]>
- Added logic to detect Fedora version from /etc/os-release. - Introduced conditional inclusion of openssl-static, protobuf-static, and python2-sphinx based on Fedora version: - openssl-static for Fedora ≤ 35 - protobuf-static for Fedora ≤ 38 - python2-sphinx for Fedora < 32, otherwise python3-sphinx for Fedora ≥ 32 - Cleaned up redundant entries in the package list (FD_LIST). - Improved error handling for unavailable packages with --skip-broken option in dnf. - Ensured compatibility with Fedora's evolving package ecosystem by addressing deprecated packages. Signed-off-by: Marco Dos Santos Oliveira <[email protected]>
Byvirven
force-pushed
the
fix-fedora-package-list
branch
from
f682ae4
to
dba89d9
Compare
|
Byvirven - is not a collaborator |
stsoe
requested changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
This commit updates the xrtdeps.sh script to fix the Fedora package installation list, ensuring compatibility with newer Fedora versions. Specifically, it addresses the absence of some packages and adapts the list dynamically based on the Fedora version.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
No specific PR introduced the issue. The problem was identified while attempting to execute the xrtdeps.sh script on Fedora 41, where several packages were missing or incompatible with the current package list. Probably not the first time.
How problem was solved, alternative solutions (if any) and why they were rejected
The problem was solved by:
Adding logic to detect the Fedora version dynamically from /etc/os-release.
Introducing conditional logic to include specific packages only for supported Fedora versions:
Alternative solutions, such as manually installing missing packages or ignoring unavailable ones, were rejected as they would not ensure compatibility across Fedora versions and could cause issues in automated environments.
Risks (if any) associated the changes in the commit
The risks are minimal, but possible issues include:
What has been tested and how, request additional testing if necessary
The updated script was tested on Fedora 41 to ensure:
Additional testing could include running the script on other Fedora versions (e.g., 35, 38) to confirm conditional logic behaves as expected.
Documentation impact (if any)
The documentation for the xrtdeps.sh script, if it exists, may need an update to reflect: