Revert "Made aie resources 0 for hw_gen greater than 1 (#8626)" #8631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bisingha-xilinx
requested review from
chvamshi-xilinx and
mamin506
as code owners
This reverts commit 715c7e7. Signed-off-by: bisingha <[email protected]>
bisingha-xilinx
force-pushed
the
master
branch
from
8cc5c16 to
09e72a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bisingha [email protected]
(cherry picked from commit 715c7e7)
Problem solved by the commit
AIE engine driver team revoked the statement "pass NULL or 0 to req.meta_data for hw_gen > 1 while requesting for aie partition". Reverting the commit as the changes are not required.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
None.
How problem was solved, alternative solutions (if any) and why they were rejected
Based on the AIE engine driver team we published the changes. Since the statement made by them is not valid reverting the changes
Risks (if any) associated the changes in the commit
None
What has been tested and how, request additional testing if necessary
Tested on vck190 and vek280 board with simple AIE only testcase.
Documentation impact (if any)
None