Made aie resources 0 for hw_gen greater than 1 #8626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bisingha <[email protected]>
bisingha-xilinx
requested review from
chvamshi-xilinx and
mamin506
as code owners
| req.partition_id = partition_id; | ||
| req.uid = 0; | ||
| req.meta_data = 0; | ||
|
|
||
| if (aie_res) | ||
| if (hw_gen == 1) |
There was a problem hiding this comment.
Remove the condition completely
There was a problem hiding this comment.
Thanks for pointing out. it is already set at 530
bisingha-xilinx
added a commit
to bisingha-xilinx/XRT
that referenced
this pull request
Nov 28, 2024
Signed-off-by: bisingha <[email protected]> (cherry picked from commit 715c7e7)
bisingha-xilinx
added a commit
to bisingha-xilinx/XRT
that referenced
this pull request
Nov 28, 2024
This reverts commit 715c7e7.
bisingha-xilinx
added a commit
to bisingha-xilinx/XRT
that referenced
this pull request
Nov 28, 2024
This reverts commit 715c7e7. Signed-off-by: bisingha <[email protected]>
chvamshi-xilinx
pushed a commit
that referenced
this pull request
Nov 28, 2024
This reverts commit 715c7e7. Signed-off-by: bisingha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
While requesting for AIE partition the meta_data of aie_partition_req should be "zero" for hw_gen greater than 1 since AIE resource loading only supported on hw_gen 1 (AIE1). Confirmed with the AIE driver team.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Customer faced issue with 2023.2 XRT (https://jira.xilinx.com/browse/CR-1220658). To avoid future similar issues fixing it on XRT master.
How problem was solved, alternative solutions (if any) and why they were rejected
making meta_data of aie_partition_req "zero" for hw_gen greater than 1.
Risks (if any) associated the changes in the commit
None
What has been tested and how, request additional testing if necessary
Tested on vck190(AIE1) and vek280(AIE2)
Documentation impact (if any)
None