cppcheck - various fixes #8622
Merged
cppcheck - various fixes #8622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add nullptr check; not that this will ever trigger, but sure, cppcheck is correct about missing nullptr check. Use override on virtual function overrides, but leave virtual if the override makes the function pure virtual for additional derived classes. Use explicit to avoid converting constructors, but allow converting constructors for classes that act more or less as alias for type. Signed-off-by: Soren Soe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Fix few cppcheck warnings
How problem was solved, alternative solutions (if any) and why they were rejected
Add nullptr check; not that this will ever trigger, but sure, cppcheck is correct about missing nullptr check.
Use override on virtual function overrides, but leave virtual if the override makes the function pure virtual for additional derived classes.
Use explicit to avoid converting constructors, but allow converting constructors for classes that act more or less as alias for type.