Skip to content

Pull Request Guidelines

sozud edited this page Jul 10, 2023 · 11 revisions

Adding commits

Once a PR has been reviewed, do not add more commits other than to resolve the comments. This makes it harder for reviewers and lengthens the time to get a PR through review.

Single purpose

A PR should ideally accomplish one thing. Good examples are:

  • Decompiling a single function
  • Renaming a symbol
  • Changing something about the build system
  • Rearranging code

A PR that does all of those things is much harder to review.