fix(cmake): ensure D is automounted when using toolchain #679
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the toolchain file, the "D" drive is not automounted as it is when using the Makefile options. This PR fixes that using the same conditions as the Makefile option.
Otherwise you must add extra bits to the code to automount, such as https://github.com/abaire/nxdk_pgraph_tests/blob/4b7934e6d612a6d17f9ec229a2d72601a5caefc4/src/main.cpp#L118-L122
This was discussed on the discord server here: https://discord.com/channels/428359196719972353/428399682239332354/1296626606688833617
It may be better to use a cmake "option" with the value set to
ON
by default, andOFF
when it desired to disable. This would be more standard for CMake, just let me know which way is preferred.Edit: converted to draft as during my first test I had not cleared the cmake cache, thus the toolchain was not fully reloaded. Need to fix some things.