cxbe: Populate debug path header fields #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayFoxRox
reviewed
Jul 5, 2023
tools/cxbe/Exe.cpp
Outdated
| @@ -158,6 +158,8 @@ Exe::Exe(const char *x_szFilename) | |||
| } | |||
| } | |||
|
|
|||
| m_debugPath = x_szFilename; | |||
There was a problem hiding this comment.
I think I'd prefer if this was an optional thing or user-controlled.
I'm concerned with leaking user-data (such as usernames) or storing unexpected data (which XBE parsers can't handle - such as non Windows paths).
There was a problem hiding this comment.
Added DEBUGPATH option.
abaire
force-pushed
the
populate_debug_file_info
branch
2 times, most recently
from
14994a7
to
42efe5a
Compare
abaire
force-pushed
the
populate_debug_file_info
branch
from
42efe5a
to
25d3a10
Compare
|
I've reviewed (and tried) the code and everything seems to be fine. I'd like to see the fix in #652 land first but once it's in I'll hit the merge button on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.