Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pbkit: Support non-standard NVCLK #585

Closed
wants to merge 1 commit into from
Closed

Conversation

GXTX
Copy link
Contributor

@GXTX GXTX commented Jun 22, 2022

Fixes #536

With the release of software based overclocks, and hardware modding becoming more popular I think pbkit should support any given frequency just as XDK does. A stock Xbox will run fine at ~250MHz and as low as ~25MHz.

@Ryzee119
Copy link
Contributor

Ryzee119 commented Jul 3, 2022

Looks pretty good, tested on my 1.6 with stock clocks and didnt break anything.
Got this output:

input freq : 233338Hz
num        : 58334
den        : 7812
timer freq : 31248Hz

Output matches the original hardcoded value of ~31.25Mhz

@GXTX
Copy link
Contributor Author

GXTX commented Jul 18, 2022

Thanks for the review. ^

@Ernegien Ernegien self-assigned this Aug 19, 2022
@Ernegien
Copy link
Member

Ernegien commented Sep 7, 2022

Closing due to lack of MIT consent.

@Ernegien Ernegien closed this Sep 7, 2022
@GXTX
Copy link
Contributor Author

GXTX commented Sep 7, 2022

The code is taken directly from Linux, I cannot re-license Linux.

@JayFoxRox
Copy link
Member

Could be rewritten to simplify fractions using a GCD, or you can find a source for fraction simplification using this algorithm to ensure it's factual / non-copyrightable (while also providing a second source).

I think it is already factual, although I don't fully understand the choice of the constant 32 and 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

pbkit quits if the nvclk freq is not default
4 participants