Add support for basic authentication for the web server. #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. I need to validate it before merging but this is a nice feature for RPi-Monitor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For my personal use, I added the "basic-auth" authentication mecasism in RPi-Monitor. When enabled, if you go to the web interface, you will be prompted for a user and password (HTTP 401 response). If the user/pass match the one in config file, you will get access to the ressource. Otherwise, you will get a new HTTP 401 response requesting a user/pass.
All browsers support "basic" auth, where the user and pass is send to the server in plain text (base64 encoded), so it is not suitable if you dont trust the network.