Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse AdditionalAddresses #204

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Parse AdditionalAddresses #204

wants to merge 1 commit into from

Conversation

farmio
Copy link
Member

@farmio farmio commented Apr 15, 2023

don't use them in the result yet.

IP Secure interfaces use BusInterface to transport name and leave the name attribute of AdditionalAddress tags an empty string. I don't know how BusInterface[@AddressIndex] relates to an AdditionalAddress tag.

Also there are no communication objects for AdditionalAddress so maybe they should have their own root key in the final result. A BusInterface may have Connectors containing their Associations as GroupAddressRefId - which doesn't really add to our current reference schema (GroupAddress -> CommunicationObject and Device -> CommunicationObject) 😬

don't use them in the result yet.
@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #204 (ed58421) into main (836beff) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   97.84%   98.00%   +0.15%     
==========================================
  Files          19       19              
  Lines         697      701       +4     
==========================================
+ Hits          682      687       +5     
+ Misses         15       14       -1     
Impacted Files Coverage Δ
xknxproject/loader/project_loader.py 98.96% <100.00%> (-0.02%) ⬇️
xknxproject/models/models.py 100.00% <100.00%> (+0.64%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant