Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExposeSensor cooldown option #1094

Merged
merged 4 commits into from
Dec 17, 2022
Merged

Add ExposeSensor cooldown option #1094

merged 4 commits into from
Dec 17, 2022

Conversation

farmio
Copy link
Member

@farmio farmio commented Dec 3, 2022

Description

  • ExposeSensor: Add cooldown option to allow rate-limiting of sent telegrams.
  • Add task.done() to TaskRegistry tasks.

See #765

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • The documentation has been adjusted accordingly
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog (docs/changelog.md)

@farmio farmio requested a review from marvin-w December 3, 2022 22:57
@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Merging #1094 (aa819e0) into main (5121ae4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1094      +/-   ##
==========================================
+ Coverage   96.30%   96.31%   +0.01%     
==========================================
  Files         138      138              
  Lines        8626     8654      +28     
==========================================
+ Hits         8307     8335      +28     
  Misses        319      319              
Impacted Files Coverage Δ
xknx/core/task_registry.py 100.00% <100.00%> (ø)
xknx/devices/expose_sensor.py 100.00% <100.00%> (ø)

@farmio
Copy link
Member Author

farmio commented Dec 3, 2022

Current implementation cancels the sending of a new value with GVWrite if it was sent via GVResponse while waiting for cooldown.

Not 100% sure if this can cause troubles - probably depends on the receivers flags Settings.

@farmio farmio merged commit 1319934 into main Dec 17, 2022
@farmio farmio deleted the expose-sensor-cooldown branch December 17, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant