Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/beta main merge #1153

Closed
wants to merge 185 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
185 commits
Select commit Hold shift + click to select a range
cd18466
Added config changes for failure queue functionality
ziggy-cyb Jul 12, 2023
3c25163
Added mysql for failure queue and promisify connection util
ziggy-cyb Jul 12, 2023
0e68c2b
Added initial implementation of sendToFailureQueue function in Webhoo…
ziggy-cyb Jul 12, 2023
6ac2180
Added method annotations to sendFailureToQueue function
ziggy-cyb Jul 12, 2023
1e34be3
Moved db connection config to sendFailureToQueue function since it is…
ziggy-cyb Jul 12, 2023
5ed3089
Moved sendToFailureQueue function to a QueueService instead for clean…
ziggy-cyb Jul 12, 2023
334c764
Added queue db username to config variables
ziggy-cyb Jul 12, 2023
2b4dbf0
Added method annotation to sendToQueue method in QueueService
ziggy-cyb Jul 12, 2023
5ab6725
Cleaned up instantiation of queue service in webhook service and logging
ziggy-cyb Jul 13, 2023
c8aeffd
Added mysql server to docker-compose for queue service
ziggy-cyb Jul 13, 2023
1c9f5ae
Made some changes to the queue service and webhook service to fix iss…
ziggy-cyb Jul 13, 2023
64a48df
Initial setup of queueModel workspace
ziggy-cyb Jul 13, 2023
b07ab5a
Added initial setup of Prisma
ziggy-cyb Jul 13, 2023
327c72d
Cleaned up build actions for queueModel
ziggy-cyb Jul 13, 2023
59c9a0f
Added starter package.json for submitter workspace
ziggy-cyb Jul 13, 2023
5189cea
Added temporary repo declaration to queueModel
ziggy-cyb Jul 14, 2023
aad8bf2
Made some changes in queueModel to fix type declaration issues
ziggy-cyb Jul 17, 2023
40ff8cf
Moved queue service calling code to status service
ziggy-cyb Jul 17, 2023
f685091
Changes to get queuemodel buildign properly as a package
ziggy-cyb Jul 17, 2023
ccab3f0
DB config
jenbutongit Jul 17, 2023
ea48730
tidy
jenbutongit Jul 17, 2023
14c07de
exit code, logs
jenbutongit Jul 17, 2023
71d5571
tidy
jenbutongit Jul 18, 2023
63941c6
Updated queueService so that it pushes to db properly using prisma
ziggy-cyb Jul 26, 2023
b9b15c0
Renamed queue plugin to match rest of plugins
ziggy-cyb Jul 26, 2023
6fb86cb
Tidied up docker compose file
ziggy-cyb Jul 26, 2023
4b8b098
Added submitter as a yarn workspace
ziggy-cyb Jul 26, 2023
a837df7
Updated status service with better logs for queue service
ziggy-cyb Jul 26, 2023
9a9f416
Updated queueModel so that it emits migrations properly and updated s…
ziggy-cyb Jul 26, 2023
b47a195
Minor changes to submitter package file
ziggy-cyb Jul 26, 2023
f94c65c
feat: allow redirects after callback submission (#1101)
jenbutongit Jul 24, 2023
ca0ac18
Rewrite of condition select component to fix issues with components w…
ziggy-cyb Jul 14, 2023
a9c477c
Added config changes for failure queue functionality
ziggy-cyb Jul 12, 2023
8eb6d26
Initial server setup for submitter
ziggy-cyb Jul 28, 2023
6b2951d
Implemented some basic config for submitter service
ziggy-cyb Jul 28, 2023
4e6994f
Added new config variables to logging plugin config
ziggy-cyb Jul 28, 2023
a2a91b1
Implemented queue plugin to submitter service
ziggy-cyb Jul 28, 2023
7d27365
Added in http service and webhook service
ziggy-cyb Jul 31, 2023
1bc9e98
Added queue service with logic for processing submissions
ziggy-cyb Jul 31, 2023
0a15fc7
Added service registration to createServer function
ziggy-cyb Jul 31, 2023
0d2d73e
Added schmervice and pino to submitter
ziggy-cyb Jul 31, 2023
78b89e1
Added cron plugin
ziggy-cyb Jul 31, 2023
6d5323b
Added cron module
ziggy-cyb Jul 31, 2023
893f59e
Updated queue service to wait for reference in response
ziggy-cyb Aug 2, 2023
d6d3666
Moved queue service specific code into queueSubmitterService subclass
ziggy-cyb Aug 2, 2023
d9ad171
Added polling interval env var for runner queueService and submitter …
ziggy-cyb Aug 2, 2023
01a3dfc
Changed submitter tsconfig.json to only check files in the src directory
ziggy-cyb Aug 2, 2023
e5f3639
Updated queue status service and queue service
ziggy-cyb Aug 2, 2023
561f899
Added queueModel build to workspace build:dependencies command
ziggy-cyb Aug 2, 2023
d837670
Latest yarn.lock file
ziggy-cyb Aug 2, 2023
d194fff
Latest yarn lock
ziggy-cyb Aug 2, 2023
27346ee
Moved poll plugin until after services are registered so that the ser…
ziggy-cyb Aug 2, 2023
26f61d1
Amended how the webhook service logs and returns data
ziggy-cyb Aug 2, 2023
03197ea
Added .env registration to default config file
ziggy-cyb Aug 2, 2023
9803db6
Amended poll plugin so it uses the queue service instantiated from th…
ziggy-cyb Aug 2, 2023
d0dff25
Updated queue service to update the submission with an error or retur…
ziggy-cyb Aug 2, 2023
7358b8d
Removed pino dep from submitter that was causing a build error
ziggy-cyb Aug 3, 2023
d092bbd
Updated docker files to allow runner to work with queue service using…
ziggy-cyb Aug 4, 2023
1bfbfc1
Updated package files to work with prisma in docker compose
ziggy-cyb Aug 4, 2023
4a95ddc
Updated designer to fix some issues with building with docker
ziggy-cyb Aug 4, 2023
3cc3a14
Latest yan lock
ziggy-cyb Aug 4, 2023
0d0469c
Latest yarn lock
ziggy-cyb Aug 4, 2023
5b6544c
Fixed designer flyout linting errors
ziggy-cyb Aug 4, 2023
b939c96
feat: add backlink fallback (#1108)
jenbutongit Aug 15, 2023
d557f07
fix: added region1 urls for GTM to content security policy (#1110)
ziggy-cyb Aug 18, 2023
e6ad9f7
Added logic to open and close connection at server start and stop level
ziggy-cyb Aug 7, 2023
f06819e
Updated prisma dependency in form runner
ziggy-cyb Aug 30, 2023
a70da99
Updated prisma chema to include retry_counter field
ziggy-cyb Aug 30, 2023
66749d5
Updated dependencies and added type deps in submitter
ziggy-cyb Aug 30, 2023
cb5df9b
Added test config to submitter service
ziggy-cyb Aug 30, 2023
6b4ff30
Updated createServer command onPreStop extension to properly close th…
ziggy-cyb Aug 30, 2023
56e8b2a
Made some changes to runner queueService
ziggy-cyb Aug 30, 2023
9b52e8f
Updated processSubmission function to accurately retrieve valid submi…
ziggy-cyb Aug 30, 2023
c3b4f98
Moved Prisma Client instance to top level of submitter
ziggy-cyb Aug 30, 2023
94f7bad
Added integration test for queue service
ziggy-cyb Aug 30, 2023
abd0e97
Added test for webhook service and moved queue service test to servic…
ziggy-cyb Aug 31, 2023
1ca2ccc
Removed unnecessary functions from http service in submitter
ziggy-cyb Aug 31, 2023
8a39066
Updated jest config and yarn lock
ziggy-cyb Aug 31, 2023
895e759
Added queueRetention workspace
ziggy-cyb Sep 1, 2023
10c58ec
Combined submitter and queueRetention workspaces
ziggy-cyb Sep 5, 2023
e216d59
Queue service changes
ziggy-cyb Sep 7, 2023
f7e5427
Updated prisma schema to make time fields DateTime fields
ziggy-cyb Sep 7, 2023
81f2519
Moved redactSubmissions to a separate file and fixed queueService uni…
ziggy-cyb Sep 7, 2023
14ee96e
Updated log for success update in queue srevice
ziggy-cyb Sep 7, 2023
ef4f23a
Updated retention index file to work with split out redactSubmission …
ziggy-cyb Sep 7, 2023
aa97065
Created prismaClient mock
ziggy-cyb Sep 7, 2023
1a4d8f6
Fixed redactSubmissions unit test
ziggy-cyb Sep 7, 2023
6c07519
Added new startup scripts for submission and retention services
ziggy-cyb Sep 7, 2023
4aa00d4
Now exporting submission type from Prisma
ziggy-cyb Sep 7, 2023
1e7b4bb
Latest yarn lock file
ziggy-cyb Sep 7, 2023
e2083f6
Added some dependencies and cleaned up config
ziggy-cyb Sep 11, 2023
84fcdf4
Added pino back into runner and added top level prisma client
ziggy-cyb Sep 11, 2023
cf0cbd3
Fixed issues with how data was returned from the runner queueService …
ziggy-cyb Sep 11, 2023
99464cc
Reset conditions files to remove changes
ziggy-cyb Sep 12, 2023
066d3cd
rename
jenbutongit Sep 13, 2023
c9ebc43
wip
jenbutongit Sep 13, 2023
f4305fc
increase retry count
jenbutongit Sep 13, 2023
2571325
tests
jenbutongit Sep 13, 2023
8ed3a22
config
jenbutongit Sep 13, 2023
7c8dd9e
build
jenbutongit Sep 13, 2023
413d88f
Merge branch 'main' into feat/queue-amends
jenbutongit Sep 13, 2023
6abaff0
resolve deps
jenbutongit Sep 13, 2023
c3888e2
Merge commit '413d88f681b7130a5d682730ad37d7e30a7bb65b' into feat/que…
jenbutongit Sep 13, 2023
0dc893e
deps
jenbutongit Sep 13, 2023
e5ce034
tidy
jenbutongit Sep 13, 2023
c9a7077
ts-jest
jenbutongit Sep 13, 2023
49e9abe
jest
jenbutongit Sep 13, 2023
1d5fc71
remove msql
jenbutongit Sep 13, 2023
f2016a8
eslint
jenbutongit Sep 13, 2023
963542a
coverage
jenbutongit Sep 13, 2023
819f7f5
add retention plugin, fix tests
jenbutongit Sep 14, 2023
5404cd2
logs
jenbutongit Sep 14, 2023
6f2b67b
hoek
jenbutongit Sep 14, 2023
2d2f8fa
hoek
jenbutongit Sep 14, 2023
db60306
resolution
jenbutongit Sep 14, 2023
842de6f
hoek
jenbutongit Sep 14, 2023
ac82cfc
remove resolve
jenbutongit Sep 14, 2023
c108c07
hoek
jenbutongit Sep 14, 2023
17699cf
allow GHSA-c429-5p7v-vgjp
jenbutongit Sep 14, 2023
a763fa4
allow?
jenbutongit Sep 14, 2023
aeb6b30
tests
jenbutongit Sep 14, 2023
d8a4f11
revert default.js
jenbutongit Sep 14, 2023
9e6c2ae
opt chain
jenbutongit Sep 14, 2023
3124001
mocks
jenbutongit Sep 14, 2023
f89b373
init
jenbutongit Sep 14, 2023
45a7a36
CI
jenbutongit Sep 14, 2023
6144b19
too many -beta
jenbutongit Sep 14, 2023
724d213
-beta
jenbutongit Sep 14, 2023
fd90041
publish
jenbutongit Sep 14, 2023
115dae8
remove beta from docker version
jenbutongit Sep 14, 2023
a7e93f3
fix: add lodash to runner
jenbutongit Sep 15, 2023
e440f3f
fix: ensure DB migration runs (#1120)
jenbutongit Sep 15, 2023
e4a0766
Fix/beta query priority (#1121)
jenbutongit Sep 15, 2023
4f41cae
fix: remove pretty print. use db.text instead of string (#1122)
jenbutongit Sep 19, 2023
362b929
Added conditional cookie statements dependent on whether matomo or gt…
ziggy-cyb Aug 31, 2023
ddacc3b
modified / route so that it redirects to start page if no default for…
ziggy-cyb Sep 20, 2023
fab0a33
Limited submissions being returned to one at a time
ziggy-cyb Oct 20, 2023
dd22d66
Moved poll from setInterval to recursive setTimeout so it can be bloc…
ziggy-cyb Oct 20, 2023
18cc63c
Updated poll plugin for better logging
ziggy-cyb Oct 23, 2023
d1195e3
Fixed setup-node action to 3.6
ziggy-cyb Oct 23, 2023
8d84fdb
Fixed setup-node version name
ziggy-cyb Oct 23, 2023
98821b8
Updated checkout action version as well
ziggy-cyb Oct 23, 2023
024243e
Updated submitter tests
ziggy-cyb Oct 23, 2023
a973582
Updated upload service error responses to use a message from the docu…
ziggy-cyb Oct 18, 2023
0f8326c
Upload service error cleanup
ziggy-cyb Oct 19, 2023
2cb4d43
Updated errors so they are kept in a ERRORS map
ziggy-cyb Oct 20, 2023
8dae8f6
Updated upload documents error so that all errors use the ERRORS map
ziggy-cyb Oct 20, 2023
0506e45
Made changes to UploadService for all returned errors to be mapped
ziggy-cyb Oct 20, 2023
236e27e
reverted parseDocumentUplaodResponse to a switch statement
ziggy-cyb Oct 20, 2023
cfd04c2
Cleaned up responses from parsedDocumentUploadResponse
ziggy-cyb Oct 20, 2023
9779155
Updated what is sent to parsedDocumentUploadResponse from error catch
ziggy-cyb Oct 20, 2023
12ec041
Added allowRetry to webhook output schema
ziggy-cyb Nov 7, 2023
3735d5a
Updated outputs edit in designer to set allowRetry to true by default
ziggy-cyb Nov 7, 2023
bda2171
Added allow_retry column to Submission db
ziggy-cyb Nov 7, 2023
6cf7e98
Updated runner to send through allowRetry value
ziggy-cyb Nov 7, 2023
4bb0ff6
Updated getSubmissions to filter out errored submissions with allowRe…
ziggy-cyb Nov 7, 2023
9d18d3f
Disabled failure on cache miss
ziggy-cyb Nov 7, 2023
b179840
Removed yarn cache from setup-node to see if that fixes caching issues
ziggy-cyb Nov 7, 2023
1506b0b
Updated schema and migration to default allow_retry to true
ziggy-cyb Nov 7, 2023
fdcc012
Changed webhook_url to be non-nullable
ziggy-cyb Nov 7, 2023
0a4364b
Updated url required migration to set the value of all null webhook_u…
ziggy-cyb Nov 8, 2023
49d38b7
Removed warning from webhook_url migration
ziggy-cyb Nov 8, 2023
366f018
Updated summaryViewModel so that webhook allowRetry flag is passed th…
ziggy-cyb Nov 10, 2023
e44ff9b
Made all error messaging labels lower case
ziggy-cyb Nov 9, 2023
cac44b3
Updated error message templates
ziggy-cyb Nov 9, 2023
d175df3
Updated failing tests
ziggy-cyb Nov 9, 2023
bfbb63f
more fixes to multiline text test
ziggy-cyb Nov 9, 2023
147be70
Final multiline test fix...
ziggy-cyb Nov 9, 2023
ff29fdb
Updated complete a form smoke test with new error
ziggy-cyb Nov 10, 2023
733eb83
Changed optional text to lower case
ziggy-cyb Nov 15, 2023
28068e7
Updated tests with optional text
ziggy-cyb Nov 15, 2023
f14b884
Updated smoke tests
ziggy-cyb Nov 15, 2023
2580fd2
feat: add more feeOptions - prevent auto submission (#1141)
jenbutongit Nov 16, 2023
2c6d66d
Added README for submitter
ziggy-cyb Nov 20, 2023
73317c5
Added docs for enabling the queue service from the runner side
ziggy-cyb Nov 20, 2023
bacb07c
Updated dependencies
ziggy-cyb Nov 20, 2023
1082422
More dependency updates
ziggy-cyb Nov 20, 2023
594d30a
Updated babel dependencies across project
ziggy-cyb Nov 21, 2023
ea5c713
Updated babel-jest packages
ziggy-cyb Nov 21, 2023
1d3092c
Added resolution for babel core
ziggy-cyb Nov 21, 2023
4e6d7ad
Updated lockfile
ziggy-cyb Nov 21, 2023
4d97185
Added resolution for babel traverse
ziggy-cyb Nov 21, 2023
9d15bb2
Allowed postcss GHSA to avoid upgrading webpack
ziggy-cyb Nov 21, 2023
a2e247a
Fixed md table formatting
ziggy-cyb Nov 22, 2023
0f3cff1
fix: change customPayErrorMessage type to string
jenbutongit Nov 22, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
{
"extends": [
"plugin:json/recommended",
"plugin:prettier/recommended"
],
"extends": ["plugin:json/recommended", "plugin:prettier/recommended"],
"plugins": ["@babel", "prettier"],
"parser": "babel-eslint",
"parser": "@babel/eslint-parser",
"env": {
"browser": true,
"es6": true,
Expand Down Expand Up @@ -38,7 +35,12 @@
{
"files": ["*.ts", "*.tsx"],
"parser": "@typescript-eslint/parser",
"plugins": ["@babel", "prettier", "@typescript-eslint", "eslint-plugin-tsdoc"],
"plugins": [
"@babel",
"prettier",
"@typescript-eslint",
"eslint-plugin-tsdoc"
],
"parserOptions": {
"ecmaFeatures": { "jsx": true }
}
Expand Down
81 changes: 81 additions & 0 deletions .github/workflows/beta--lint-unit-build-and-publish-images.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
name: Beta QA
on:
push:
branches:
- beta

jobs:
calculate-version:
runs-on: ubuntu-latest
outputs:
semVer: ${{ steps.gitversion.outputs.semVer }}
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0
branches: main

- name: Install GitVersion
uses: gittools/actions/gitversion/[email protected]
with:
versionSpec: "5.x"

- name: Determine Version
id: gitversion
uses: gittools/actions/gitversion/[email protected]
with:
useConfigFile: true

assign-semver:
runs-on: ubuntu-latest
needs: [calculate-version]
env:
SEMVER: ${{ needs.calculate-version.outputs.semVer }}
MAJOR: ${{ needs.calculate-version.outputs.Major }}
outputs:
SEMVER: ${{ steps.calc-semver.outputs.semver }}
steps:
- run: echo $SEMVER
- name: Add 3 to calculated semver
run: |
echo SEMVER="$((3 + MAJOR))${SEMVER:1}" >> $GITHUB_ENV
- name: Set semver to output
id: calc-semver
run: echo "::set-output name=semver::$(echo $SEMVER)"

lint-and-test:
name: Workspace
strategy:
matrix:
workspace: [model, designer, runner, submitter]
uses: ./.github/workflows/lint-and-test.yml
with:
workspace: ${{ matrix.workspace }}

build-and-publish-images:
name: Build and publish
needs: [calculate-version, assign-semver, lint-and-test]
strategy:
matrix:
app: [designer, runner, submitter]
uses: ./.github/workflows/build.yml
secrets: inherit
with:
semver: ${{ needs.assign-semver.outputs.SEMVER }}
publish: true
app: ${{matrix.app}}

tag-branch:
runs-on: ubuntu-latest
needs: [calculate-version, assign-semver, build-and-publish-images]
env:
SEMVER: ${{ needs.assign-semver.outputs.SEMVER }}
steps:
- name: Checkout repo
uses: actions/checkout@v2
with:
token: ${{ secrets.GHCR_PAT }}
- name: Tag branch with run number
run: |
git tag ${{ env.SEMVER }}
git push --tags origin HEAD
12 changes: 10 additions & 2 deletions .github/workflows/branch--lint-unit-and-smoke-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
pull_request:
branches:
- main
- beta
paths-ignore:
- "docs/**"
- "**/README.md"
Expand All @@ -18,7 +19,7 @@ jobs:
name: Workspace
strategy:
matrix:
workspace: [model, designer, runner]
workspace: [model, designer, runner, submitter]
uses: ./.github/workflows/lint-and-test.yml
with:
workspace: ${{ matrix.workspace }}
Expand All @@ -30,6 +31,13 @@ jobs:
app: designer
secrets: inherit

build-submitter:
name: Submitter
uses: ./.github/workflows/build.yml
with:
app: submitter
secrets: inherit

build-runner:
name: Runner
uses: ./.github/workflows/build.yml
Expand All @@ -38,7 +46,7 @@ jobs:
secrets: inherit

smoke-test:
needs: [build-runner,build-designer]
needs: [build-runner, build-designer]
uses: ./.github/workflows/smoke-test.yml
with:
runner-cache-ref: ${{needs.build-runner.outputs.tag}}
Expand Down
10 changes: 4 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
workflow_call:
inputs:
app:
description: the app to build "designer" or "runner"
description: the app to build "designer", "runner" or "submitter"
required: true
type: string
publish:
Expand All @@ -23,7 +23,6 @@ on:
description: hash used for docker caching
value: ${{ jobs.build-app.outputs.hash }}


jobs:
build-app:
if: ${{!contains(github.event.head_commit.message, 'chore(deps-dev)')}}
Expand All @@ -33,12 +32,11 @@ jobs:
tag: ${{ steps.hashFile.outputs.tag }}
hash: ${{ steps.hashFile.outputs.hash }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v3.6.0
- name: Use Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v3.6.0
with:
node-version: "16.x"
cache: yarn

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand All @@ -51,6 +49,7 @@ jobs:
key: ${{ runner.os }}-yarn-${{inputs.app}}-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-${{inputs.app}}
fail-on-cache-miss: false

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
Expand All @@ -65,7 +64,6 @@ jobs:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}


# The hash is a function of the Dockerfile and the yarn.lock Packages take up the bulk of the time during a docker build. The hash is used to cache the docker builds.
# As long as the yarn.lock and dockerfiles are the same, you will be able to share this cache with another commit/branch.
- id: hashFile
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/dependency-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
# Source repository: https://github.com/actions/dependency-review-action
# Public documentation: https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/about-dependency-review#dependency-review-enforcement
name: 'Dependency Review'
name: "Dependency Review"
on: [pull_request]

permissions:
Expand All @@ -14,7 +14,11 @@ jobs:
dependency-review:
runs-on: ubuntu-latest
steps:
- name: 'Checkout Repository'
- name: "Checkout Repository"
uses: actions/checkout@v3
- name: 'Dependency Review'
- name: "Dependency Review"
uses: actions/dependency-review-action@v2
with:
allow-ghsas:
- GHSA-c429-5p7v-vgjp
- GHSA-7fh5-64p2-3v2j
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
name: Workspace
strategy:
matrix:
workspace: [ model, designer, runner ]
workspace: [model, designer, runner, submitter]
uses: ./.github/workflows/lint-and-test.yml
with:
workspace: ${{ matrix.workspace }}
Expand All @@ -71,7 +71,7 @@ jobs:
secrets: inherit
strategy:
matrix:
app: [ designer, runner ]
app: [designer, runner]
with:
app: ${{ matrix.app }}
tag: ${{ needs.assign-semver.outputs.SEMVER }}
Expand Down
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,7 @@ tsconfig.tsbuildinfo
docs/**/typedoc

/e2e/cypress/screenshots/
.env_mysql
/queue-model/dist
/queue-model/module
/queue-model/src/prisma/generated
8 changes: 4 additions & 4 deletions babel.config.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
"exclude": ["node_modules/**"],
"plugins": [
"@babel/plugin-proposal-export-default-from",
"@babel/plugin-proposal-class-properties",
"@babel/plugin-proposal-private-property-in-object",
"@babel/plugin-proposal-private-methods",
"@babel/plugin-transform-class-properties",
"@babel/plugin-transform-private-property-in-object",
"@babel/plugin-transform-private-methods",
"@babel/plugin-transform-runtime",
"@babel/plugin-syntax-jsx",
"@babel/plugin-proposal-logical-assignment-operators"
"@babel/plugin-transform-logical-assignment-operators"
]
}
11 changes: 5 additions & 6 deletions designer/babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,14 @@ module.exports = {
],
],
plugins: [
"@babel/plugin-proposal-class-properties",
"@babel/plugin-proposal-private-methods",
"@babel/plugin-transform-class-properties",
"@babel/plugin-transform-private-methods",
"@babel/plugin-syntax-dynamic-import",
"@babel/plugin-transform-runtime",
"@babel/plugin-proposal-export-default-from",
"@babel/plugin-proposal-nullish-coalescing-operator",
"@babel/plugin-proposal-optional-chaining",
"@babel/plugin-proposal-logical-assignment-operators",

"@babel/plugin-transform-nullish-coalescing-operator",
"@babel/plugin-transform-logical-assignment-operators",
"@babel/plugin-transform-optional-chaining",
[
"module-resolver",
{
Expand Down
14 changes: 14 additions & 0 deletions designer/client/__mocks__/tabbable.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
const lib = jest.requireActual("tabbable");
const tabbable = {
...lib,
tabbable: (node, options) =>
lib.tabbable(node, { ...options, displayCheck: "none" }),
focusable: (node, options) =>
lib.focusable(node, { ...options, displayCheck: "none" }),
isFocusable: (node, options) =>
lib.isFocusable(node, { ...options, displayCheck: "none" }),
isTabbable: (node, options) =>
lib.isTabbable(node, { ...options, displayCheck: "none" }),
};

module.exports = tabbable;
28 changes: 22 additions & 6 deletions designer/client/components/Flyout/Flyout.tsx
Original file line number Diff line number Diff line change
@@ -1,31 +1,47 @@
import React, { useContext, useEffect, useLayoutEffect, useState } from "react";
import React, {
CSSProperties,
ReactChildren,
useContext,
useLayoutEffect,
useState,
} from "react";
import FocusTrap from "focus-trap-react";
import { FlyoutContext } from "../../context";
import { DataContext } from "../../context";
import { i18n } from "../../i18n";

import "./Flyout.scss";
import { bool } from "aws-sdk/clients/signer";

export function useFlyoutEffect(props: {}) {
interface Props {
style: string;
width?: string;
onHide: () => void;
closeOnEnter: (e) => void;
show: boolean;
offset: number;
title?: string;
children?: ReactChildren;
NEVER_UNMOUNTS?: boolean;
}

export function useFlyoutEffect(props: Props) {
const flyoutContext = useContext(FlyoutContext);
const [offset, setOffset] = useState(0);
const [style, setStyle] = useState();
const [style, setStyle] = useState<CSSProperties>();
const show = props.show ?? true;

/**
* @code on component mount

Check warning on line 33 in designer/client/components/Flyout/Flyout.tsx

View workflow job for this annotation

GitHub Actions / Workspace (designer) / lint and test designer

tsdoc-undefined-tag: The TSDoc tag "@code" is not defined in this configuration

Check warning on line 33 in designer/client/components/Flyout/Flyout.tsx

View workflow job for this annotation

GitHub Actions / Workspace (designer) / lint and test designer

tsdoc-undefined-tag: The TSDoc tag "@code" is not defined in this configuration
*/
useLayoutEffect(() => {
flyoutContext.increment();
return function cleanup() {
flyoutContext.decrement();
};
}, []);

Check warning on line 40 in designer/client/components/Flyout/Flyout.tsx

View workflow job for this annotation

GitHub Actions / Workspace (designer) / lint and test designer

React Hook useLayoutEffect has a missing dependency: 'flyoutContext'. Either include it or remove the dependency array

Check warning on line 40 in designer/client/components/Flyout/Flyout.tsx

View workflow job for this annotation

GitHub Actions / Workspace (designer) / lint and test designer

React Hook useLayoutEffect has a missing dependency: 'flyoutContext'. Either include it or remove the dependency array

useLayoutEffect(() => {
setOffset(flyoutContext.count);
}, []);

Check warning on line 44 in designer/client/components/Flyout/Flyout.tsx

View workflow job for this annotation

GitHub Actions / Workspace (designer) / lint and test designer

React Hook useLayoutEffect has a missing dependency: 'flyoutContext.count'. Either include it or remove the dependency array

Check warning on line 44 in designer/client/components/Flyout/Flyout.tsx

View workflow job for this annotation

GitHub Actions / Workspace (designer) / lint and test designer

React Hook useLayoutEffect has a missing dependency: 'flyoutContext.count'. Either include it or remove the dependency array

useLayoutEffect(() => {
if (offset > 0) {
Expand Down Expand Up @@ -58,7 +74,7 @@
return { style, width: props?.width, closeOnEnter, onHide, offset, show };
}

export function Flyout(props) {
export function Flyout(props: Props) {
const {
style,
width = "",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const { test, describe, beforeEach, afterEach } = lab;
function HookWrapper(props) {
const hook = props.hook ? props.hook() : undefined;
// @ts-ignore
// eslint-disable-next-line react/no-unknown-property
return <div hook={hook} />;
}

Expand Down
1 change: 1 addition & 0 deletions designer/client/outputs/output-edit.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ class OutputEdit extends Component<Props, State> {
case OutputType.Webhook:
outputConfiguration = {
url: formData.get("webhook-url") as string,
allowRetry: true,
};
break;
}
Expand Down
1 change: 1 addition & 0 deletions designer/client/outputs/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export type NotifyOutputConfiguration = {

export type WebhookOutputConfiguration = {
url: string;
allowRetry: boolean;
};

export type OutputConfiguration =
Expand Down
Loading
Loading