Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/cookies-policy-allow-js #1148

Merged
merged 1 commit into from
Nov 23, 2023
Merged

fix/cookies-policy-allow-js #1148

merged 1 commit into from
Nov 23, 2023

Conversation

ziggy-cyb
Copy link
Collaborator

Description

The cookies_policy cookie is currently http only, meaning that gtm can't access it to work out what to do with the cookies. This change removes the http only flag from the cookie.

note: kept previous structure of state since merging the two objects caused the cookie to not be set at all.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce
the testing if necessary.

  • Manually tested to check the cookie was being set without the httpOnly flag

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and versioning
  • I have updated the architecture diagrams as per Contribute.md OR added an architectural decision record entry

@ziggy-cyb ziggy-cyb force-pushed the fix/cookies-policy-allow-js branch from eff02bb to 076e273 Compare November 23, 2023 11:34
@ziggy-cyb ziggy-cyb merged commit 68e1b6a into main Nov 23, 2023
12 checks passed
@ziggy-cyb ziggy-cyb deleted the fix/cookies-policy-allow-js branch November 23, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants