Feat/templating #1142
Merged
Feat/templating #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenbutongit
requested changes
Nov 16, 2023
| @@ -90,3 +91,34 @@ export const addClassOptionIfNone = ( | |||
| options.classes = className; | |||
| } | |||
| }; | |||
|
|
|||
| export function getVarsFromContent(content: string) { | |||
There was a problem hiding this comment.
I think we should probably just use njks and renderString in this case.
We should also add an environment variable ALLOW_USER_TEMPLATES.
If true - we'll use njks and render. It looks like it could be pretty easy to inject script tags otherwise
ziggy-cyb
force-pushed
the
feat/templating
branch
2 times, most recently
from
711dabb to
3d80617
Compare
jenbutongit
requested changes
Nov 24, 2023
| @@ -90,3 +92,33 @@ export const addClassOptionIfNone = ( | |||
| options.classes = className; | |||
| } | |||
| }; | |||
|
|
|||
| export function getVarsForTemplate( | |||
| @@ -420,8 +440,7 @@ export class PageControllerBase { | |||
| } | |||
| }); | |||
| } | |||
|
|
|||
| const viewModel = this.getViewModel(formData, num); | |||
| const viewModel = this.getViewModel(formData, num, undefined, state); | |||
There was a problem hiding this comment.
why does state need to be passed in?
| @@ -88,14 +88,15 @@ export class ComponentCollection { | |||
| getViewModel( | |||
| formData: FormData | FormSubmissionState, | |||
| errors?: FormSubmissionErrors, | |||
| conditions?: FormModel["conditions"] | |||
| conditions?: FormModel["conditions"], | |||
| state?: FormSubmissionState | |||
There was a problem hiding this comment.
do we still need state, now that formData should have it?
…string.prototype.matchAll
…s "exposeToContext" flag
ziggy-cyb
force-pushed
the
feat/templating
branch
from
31dfbf4 to
9ffa258
Compare
jenbutongit
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes if there's a lot of variable content in a form, setting conditions for each bit of content can become cumbersome and in serious cases can cause the form runner to crash. Using templating we can allow conditional content to be populated based on previous user input without the need for conditions.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce
the testing if necessary.
Checklist: