Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/submitter performance #1131

Merged
merged 7 commits into from
Oct 24, 2023
Merged

fix/submitter performance #1131

merged 7 commits into from
Oct 24, 2023

Conversation

ziggy-cyb
Copy link
Collaborator

Description

The submitter would run into problems if there were multiple submissions being processed at once, running into issues with duplicating submissions, or hitting memory limits and crashing. This PR should fix these issues by better pacing submission processing.

  • Changed poll plugin to be a recursive function. This blocks new submissions from processing while a submission is being processed, but still allows polling on a timed basis
  • Changed queue service to only grab one submission at a time. This stops from too many webhook requests to run at the same time

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce
the testing if necessary.

  • Manual testing with a local endpoint and db instance

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and versioning
  • I have updated the architecture diagrams as per Contribute.md OR added an architectural decision record entry

@ziggy-cyb ziggy-cyb changed the base branch from main to beta October 23, 2023 12:09
@ziggy-cyb ziggy-cyb merged commit 024243e into beta Oct 24, 2023
@ziggy-cyb ziggy-cyb deleted the fix/submitter-performance branch October 24, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants