Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option for recently AIRED items #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

amitkeret
Copy link

Similar to another pull request that was rejected.
The former pull request added a sub-option in "Recent Items", to choose whether these will be sorted by date added or date released.
I rewrote that request, now it's a completely separate section to be switched on/off.

@bradsk88
Copy link

This commit seems to work well and followed the API put forth by this service.

Can we get a pull?

bradsk88 added a commit to bradsk88/skin.aeonmq5 that referenced this pull request Mar 22, 2014
This functionality requires this *currently unmerged* addition to the skin widgets addon:
XBMC-Addons/service.skin.widgets#18
@amitkeret
Copy link
Author

Hi @MartijnKaijser

I've noticed you released newer version to XBMC's mirrors.
Can you explain why this PR is not pulled? Is something missing in the implementation?

I'd really like to see this added, also I think other skinners will benefit. I'm using this in my skin to display "recently aired" list, I believe others would want it also.

Here's a thread about it in xbmc.org:
http://forum.xbmc.org/showthread.php?tid=174013

@henryford
Copy link

@MartijnKaijser:

Still waiting for an answer... This is a feature asked for by many, and yet you refuse to implement it. Any reason why?

@amitkeret amitkeret force-pushed the 20140126-amitk-RecentAired branch from b4632e8 to 9b3349e Compare February 28, 2015 07:57
@amitkeret
Copy link
Author

@ronie @MartijnKaijser
Can I get a comment on why this has not been merged?
Is there a problem with the code?

It would be really helpful to see this implemented in skins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants