-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template fix + more mod support + credits rename #345
base: main
Are you sure you want to change the base?
Conversation
I still don't see why you went so far out of scope instead of just adding what you already had like requested. I'm certainly not sorting through all these changes, or the multiple versions you've introduced. |
Also the changes you've made to the existing templates are invalid/do not work. |
Fair, the inability to use groups in groups is too much of a limitation though, having it in a python pip package is very nice too (though I have not tested if it works yet) |
Yeah... |
And that's where you lose me, because you had no problem making all these changes in the block.properties file directly, where you don't have any kind of templating/grouping at all. But when asked to update the templates which at least support groups, it's now not enough for you? Also it doesn't look like you've even run your templater on this branch, because there are no changes to any of the final block/entity/item files, nor any changes in the define files. |
I thought that if I have to use templates, at least it should have a greater use case. |
…arden support + more automation
Just want to be clear here, auto-numbering and auto-defines are the entire reason these templates exist, and were added by me for floodfill in Bliss. Manually updating/synchronizing hundreds of indices without it is not maintainable. Any group/variable features beyond that are purely for convenience. If you want to change tooling and take over floodfill/template support that's fine by me and between you and xonk. |
Well, I won't say yes as I have no idea what responsibilities come with that. I don't know how to write shaders (yet!). I can make small edits and add mod support to modded blocks in properties files, but I'm afraid that will be it After most recent commits, there is a chance that the PoTater property files are working, you should give iProperties a try, it does support the auto numbering as well, but if you don't want to you can fix (if broken) the new PoTater properties files and edit them, and I will then bring the edits into my iProperties |
I fixed the template files, they still miss some of the optimisations that can be done in both PoTater and iProperties
I've made my own template preprocessor named iProperties that allowes for some additional automation that leads to the reduction of work. It is also easy to work with.
IDK how well iProperties to PoTater conversion works at this moment, but I can fix remaining conversion bugs, and you can keep only PoTater version while I will keep iProperties at least until PoTater implements support for using groups inside the groups, the format differences are minimal.