Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP FPM #211

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

frankvanhest
Copy link

No description provided.

@frankvanhest frankvanhest mentioned this pull request Nov 28, 2022
@WyriHaximus
Copy link
Member

Waiting for docker-library/official-images#13602 to be merged.

@WyriHaximus
Copy link
Member

@frankvanhest I think you swapped some commit around 😅

@frankvanhest
Copy link
Author

@frankvanhest I think you swapped some commit around 😅

What do you mean?

@WyriHaximus
Copy link
Member

These are the changes for including FPM tags, not changes in the excludes file as I suggested here: #210 (comment)

@frankvanhest
Copy link
Author

I see what you mean I think. I’ll try to look into it as soon as possible. It is a bit busy at home at the moment with family and so.

@WyriHaximus
Copy link
Member

Take your time, family and so is always more important :)

@WyriHaximus
Copy link
Member

WyriHaximus commented Dec 11, 2022

@frankvanhest FYI since 8.2.0 final is out I'll get that out once tomorrow morning's build is in and hopefully resolves a CVE. If you manage to update this PR before that I'll merge it. But don't see this as pressure, we'll figure out something else to do for you so you can iterate quickly for the FPM work you're doing :).

@frankvanhest
Copy link
Author

@WyriHaximus, I jus saw your message. It is not yet ready to be merged. It still needs testing. So don't wait for this to continue rolling out PHP 8.2.

@WyriHaximus
Copy link
Member

@frankvanhest Cool, so this will become the FPM pr? Then I'll update the title. And I'm currently fighting xdebug for 8.2 😂 .

@WyriHaximus WyriHaximus changed the title Prepare for RC7 Add PHP FPM Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants