Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Chicago Java User’s Group + include Mastodon link #76

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

FDelporte
Copy link
Contributor

A proposal to add Mastodon links, related to #10.
At this point we can conclude Mastodon is an important one to add.
I have no experience with the formatting so the if's in index.html may be wrong, but didn't manage to build on my PC so not sure...

@icougil icougil changed the title Feature/#10 Added Chicago Java User’s Group + include Mastodon link Sep 14, 2023
@icougil
Copy link
Collaborator

icougil commented Sep 14, 2023

Thank you Frank for your contribution 👍!
I think the links looks ok for the index.html. I'll prepare another PR to include the Mastodon link in the map 😉
I'm not 100% sure what we can do with the email field or where we should display it.... 🤔

@icougil icougil merged commit 24d8959 into World-Wide-JUGs:master Sep 14, 2023
@FDelporte FDelporte deleted the feature/#10 branch September 15, 2023 06:32
@FDelporte
Copy link
Contributor Author

thanks for merging and also adding to the map!
found out I didn't add target="_blank" to the links, so made a new merge request...

@icougil
Copy link
Collaborator

icougil commented Sep 15, 2023

Thx Frank!
I already added the thing about opening a new window from the map.
I was not 100% sure if this is something we expect from the "simple list", but I saw you already created that PR ;-) (not an issue from my POV)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants