Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation warning #97

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Add deprecation warning #97

merged 1 commit into from
Oct 15, 2021

Conversation

mh-northlander
Copy link
Collaborator

#68.

@eiennohito
Copy link
Collaborator

Does this gets printed only once or on every usage?

@mh-northlander
Copy link
Collaborator Author

This uses python's warning system.
By default, only the first occurrence will be printed if it is used in __main__.

ref: https://docs.python.org/3/library/warnings.html#:~:text=category%20for%20warn().-,DeprecationWarning,-Base%20category%20for

@eiennohito
Copy link
Collaborator

For reference: PyErr::warn calls PyErr_WarnEx.

@mh-northlander mh-northlander merged commit b18bb43 into WorksApplications:develop Oct 15, 2021
@mh-northlander mh-northlander deleted the deprecate-api branch October 15, 2021 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eiennohito eiennohito eiennohito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mh-northlander @eiennohito