Python compatibility #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we let |
eiennohito
approved these changes
Oct 8, 2021
|
Yes, accepting and ignoring logger parameter is OK. |
eiennohito
reviewed
Oct 8, 2021
python/src/tokenizer.rs
Outdated
| fn tokenize( | ||
| &self, | ||
| text: &str, | ||
| mode: Option<PySplitMode>, | ||
| enable_debug: Option<bool>, // want to take logger instead of debug flag | ||
| logger: Option<PyObject>, | ||
| enable_debug: Option<bool>, |
There was a problem hiding this comment.
I think that it is a bad idea to expose enable_debug here.
Current implementation of debug output is a placeholder, we should not expose it to Python.
eiennohito
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #52.
Dictionary.close()SplitModealso underTokenizer