Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mv pyprojector to projection mod, organize required_field constructio #283

Merged
merged 1 commit into from
Dec 4, 2024
Merged

mv pyprojector to projection mod, organize required_field constructio #283

merged 1 commit into from
Dec 4, 2024
+60 −73

Conversation

mh-northlander
Copy link
Collaborator

organize the projection code.

  • combine projection resolution
    • perform in single if-else branch, removing resolve_projection
  • required word info fields depends only on the projection
    • calculate and return as a tuple of (proj, fields)
  • pyprojector = None is equivalent to the surface projection
    • use None for the simplification

also see #259

@mh-northlander mh-northlander merged commit 287f3d7 into WorksApplications:develop Dec 4, 2024
8 checks passed
@mh-northlander mh-northlander deleted the refactor/pyprojector branch December 4, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazuma-t kazuma-t kazuma-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mh-northlander @kazuma-t