Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Python API #68

Closed
mh-northlander opened this issue Oct 7, 2021 · 2 comments
Closed

Change Python API #68

mh-northlander opened this issue Oct 7, 2021 · 2 comments
Labels
python Python binding-related
Milestone
0.6

Comments

@mh-northlander
Copy link
Collaborator

relates to #52.

Some of the current python APIs seems not necessary (e.g. MorphemeList.split).
We may provide better way to do.
@eiennohito eiennohito added the python Python binding-related label Oct 8, 2021
@mh-northlander
Copy link
Collaborator Author

mh-northlander commented Oct 12, 2021 •
edited
Loading

API to remove:

  • MorphemeList.empty
    • MorphemeList (and Morpheme) should be provided via Tokenizer and users should not generate them by themselves.
  • Morpheme.get_word_info
    • WordInfo is too raw to expose. We provide necessary data via Morpheme.
  • Morpheme.split()

add deprecated attribute

@mh-northlander mh-northlander mentioned this issue Oct 14, 2021
Merged
@mh-northlander mh-northlander added this to the 0.1 milestone Oct 19, 2021
@mh-northlander
Copy link
Collaborator Author

Close this for now, since we don't have a plan for additional changes in the first release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
python Python binding-related
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
2 participants
@eiennohito @mh-northlander