Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Render Callout blocks as Notice blocks" #659

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

adamwoodnz
Copy link
Contributor

@adamwoodnz adamwoodnz commented Oct 22, 2024

Reverts #658

add_filter( 'the_content', array( 'o2', 'add_json_data' ), 999999 ); is breaking content rendering.

@adamwoodnz adamwoodnz merged commit 80dfeb4 into trunk Oct 22, 2024
2 checks passed
@adamwoodnz adamwoodnz deleted the revert-658-try/render-callout-as-notice branch October 22, 2024 22:01
adamwoodnz added a commit that referenced this pull request Oct 22, 2024
adamwoodnz added a commit that referenced this pull request Oct 22, 2024
* Revert "Revert "Render Callout blocks as Notice blocks (#658)" (#659)"

This reverts commit 80dfeb4.

* Only disable o2 filters if the class exists
adamwoodnz added a commit that referenced this pull request Oct 23, 2024
adamwoodnz added a commit that referenced this pull request Oct 24, 2024
* Revert "Revert "Render Callout blocks as Notice blocks (#658)" (#659)"

This reverts commit 80dfeb4.

* Only disable o2 filters if the class exists

* Stop running filters on callout content

* Switch to using CSS to avoid o2 script tags from affecting layout

Hide empty p tags and remove margin from second to last element if there is an o2-data script tag.

* Allow for first or last elements being empty

Adjust margins on second and second to last elements accordingly

* 💄 Move comment

* Fix scope for content layout adjustments

* Fix br selectors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant