Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO: Change separator to pipe. #384

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

StevenDufresne
Copy link
Contributor

Most of our subsites use a "|" as a separator. This PR updates the main theme to use the "|" separator as well.

This has come up as a result of working on #375.

Example

URL Title
/patterns Block Pattern Directory | WordPress.org
/showcase Star-studded sites built with WordPress | WordPress.org
/plugins WordPress Plugins | WordPress.org

Currently, the main theme doesn't enforce that pattern and we get the default "-" separator.

Copy link
Contributor

@ryelle ryelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

If this is the expected format, maybe it's something we should move to site-branding.php mu-plugin?

source/wp-content/themes/wporg-main-2022/functions.php Outdated Show resolved Hide resolved
@StevenDufresne
Copy link
Contributor Author

Looks good.

If this is the expected format, maybe it's something we should move to site-branding.php mu-plugin?

Yeah, that's a good call. I move this change over there and close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants