feature(mvp): Stage 2 - add initial model classes #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhooks
force-pushed
the
feature/add-models
branch
from
8660510
to
fdcc48f
Compare
johnhooks
added
the
[Scope] Model
johnhooks
changed the title
johnhooks
changed the title
johnhooks
force-pushed
the
feature/add-models
branch
2 times, most recently
from
50a7c75
to
7d4a4b7
Compare
johnhooks
force-pushed
the
feature/add-models
branch
2 times, most recently
from
a343153
to
5141476
Compare
johnhooks
force-pushed
the
feature/add-models
branch
from
7442474
to
0a9dd59
Compare
johnhooks
force-pushed
the
feature/add-models
branch
from
0a9dd59
to
bc0ac29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add the initial models
Model\ChannelModel\MessageModel\NotificationModel\SubscriptionWhy?
These are the base of models developed in #259.
Notes
All the properties are nullable, because I intend to support the
_fieldsrest option, which means the models might not be initialized with all of their properties, just what the api has requested. I’ll build that in later, but currently thejsonSerializefunction always returns all property’s of the model, I think this is fine for now. I will build out a validation system that will actually ensure the model properties are valid on insert and update.