Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: mvp #259

Closed
wants to merge 4 commits into from
Closed

feature: mvp #259

wants to merge 4 commits into from

Conversation

johnhooks
Copy link
Collaborator

@johnhooks johnhooks commented Apr 12, 2023

What?

Create a minimum viable product of the notification plugin.

Why?

There is still a lot to learn, but we need a minimally functional system to explore the possiblities.

How?

Combines PRs:

Necessary functionality for MVP*

  • Activate
  • Uninstall
  • Classes
    • Channel
    • Channel_Registry
    • Message
    • Message_Factory
    • Notice
    • Notice_Factory
    • Subscription
    • Subscription_Factory
  • Database
    • Messages table
    • Queue table
    • Subscriptions table
    • Message_Repository
    • Notice_Repository (the queue table)
    • Subscription_Repository
  • REST API
    • Notification_Controller wp-notifications/v1/notifications
      • GET /notifications/
      • GET /notifications/{id}
      • POST /notifications/{id}
      • PUT /notifications /{id}
      • DELETE /notifications /{id}
    • Subscription_Controller wp-notifications/v1/subscriptions
      • GET /subscriptions/
      • GET /subscriptions/{id}
      • POST /subscriptions/{id}
      • PUT /subscriptions /{id}
      • DELETE /subscriptions /{id}
  • CLI Command
    • Seed users
    • Seed subscriptions
    • Seed notification messages
    • List registered channels
    • List user's notifications
    • List user's subscriptions
  • Only a rough outline right now, and heavily concentrated on the backend.

@Sephsekla
Copy link
Collaborator

This is looking phenomenal already, thanks for the hard work here!

@johnhooks
Copy link
Collaborator Author

@Sephsekla thanks, it feels like its coming a long well. Right now I'm going for simple, a lot will need adjusting to make the rest api function the way I would expect. Right now I don't have the right features in the models/factories/repositories for supporting _embed or _fields parameters in the rest api. But I am saving optimization and streamlining for later. For right now, we really just need to basic CRUD actions to get off the ground.

@Sephsekla Sephsekla linked an issue Apr 26, 2023 that may be closed by this pull request
8 tasks
@Sephsekla
Copy link
Collaborator

@johnhooks when you have a sec, do you mind having a look at these merge conflicts? I'd like to try and get this rolling again by splitting out some of the remaining work (and possibly merging this one to development as is), but I'm not sure how to reslve things.

@johnhooks
Copy link
Collaborator Author

@Sephsekla this branch should actually be closed, all of the features of this branch have already been merged in. I brought all of this into develop through smaller PRs.

@johnhooks johnhooks closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimum Viable Product - v0.3.0
3 participants