Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new hooks to allow additional processing #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add new hooks to allow additional processing #23

wants to merge 1 commit into from

Conversation

jfarthing84
Copy link

Adds two new hooks, before_process_import and after_process_import, to make it more intuitive to add additional processing to the import process.

Adds two new hooks, `before_process_import` and `after_process_import`, to make it more intuitive to add additional processing to the import process.
@jrfnl
Copy link
Member

jrfnl commented Dec 23, 2017

@jfarthing84 It might be helpful to add docblocks for each of the new hooks ?

@dd32
Copy link
Member

dd32 commented Feb 12, 2018

Should some kind of context/extra information be provided to these hooks to make them more useful?

@jfarthing84
Copy link
Author

No, not really.

@dd32
Copy link
Member

dd32 commented Feb 16, 2018

Not even $this?

@jfarthing84
Copy link
Author

The other actions called in this plugin have no arguments, why should these? It wouldn't hurt, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants