PHP 8.4 | Remove use of xml_set_object() #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dd32 While not strictly necessary for WP Core, I still think it would be good to tag a new release once this is merged to prevent end-user reports about the deprecations once PHP 8.4 gets released. Also be aware that - aside from the other PRs I already opened, I have one more PR lined up (to enable running the tests against PHP 8.4, but it needs this PR to allow for a passing build). A detailed analysis of WP vs PHP 8.4 is available here: https://core.trac.wordpress.org/ticket/62061 This is the summary from that report which relates to the Importer plugin:
|
swissspidy
approved these changes
Oct 1, 2024
jrfnl
added a commit
to jrfnl/wordpress-develop
that referenced
this pull request
Oct 3, 2024
PHP 8.4 is expected to be released at the end of November 2024. Trac ticket 62061 contains a full analysis of the changes needed for WP to be ready for PHP 8.4 and all currently available patches for WP Core have been merged in the mean time. Enabling the tests to run in CI on PHP 8.4 allows WordPress core to prevent new PHP 8.4 compatibility issues from being introduced. Notes: * While a [patch has been pulled](WordPress/wordpress-importer#172) for the Importer plugin, this patch has not been merged yet. This means there are currently still five failing tests. These failure are directly related to the Importer plugin and will be fixed once the PR for the plugin has been merged. To still allow WP Core to start structurally testing against PHP 8.4, these five tests have been set up now to be skipped on PHP 8.4. These tests skips should be removed again once the PR to the plugin has been merged. * Xdebug-related tests will not be run on PHP 8.4 at this time as the Docker image for PHP 8.4 does not contain Xdebug yet. Once a stable release of Xdebug 3.4.0 is available, it can be added to the Docker image and the test step can then be enabled for PHP 8.4.
This was referenced Oct 3, 2024
Build/Test Tools: Enable running the tests on PHP 8.4 (Trac: 62061)
WordPress/wordpress-develop#7379
Closed
xxsimoxx
approved these changes
Oct 4, 2024
Merged
dd32
approved these changes
Oct 18, 2024
|
@dd32 Want me to rebase the PR to make it mergable again ? |
|
@jrfnl yes please, could you rebase it so it can be mergeable again? We'll include this in our next release. Thanks for pointing this out! |
The XML Parser extension still supports a quite dated mechanism for method based callbacks, where the object is first set via `xml_set_object()` and the callbacks are then set by passing only the name of the method to the relevant parameters on any of the `xml_set_*_handler()` functions. ```php xml_set_object( $parser, $my_obj ); xml_set_character_data_handler( $parser, 'method_name_on_my_obj' ); ``` Passing proper callables to the `xml_set_*_handler()` functions has been supported for the longest time and is cross-version compatible. So the above code is 100% equivalent to: ```php xml_set_character_data_handler( $parser, [$my_obj, 'method_name_on_my_obj'] ); ``` The mechanism of setting the callbacks with `xml_set_object()` has now been deprecated as of PHP 8.4, in favour of passing proper callables to the `xml_set_*_handler()` functions. This is also means that calling the `xml_set_object()` function is deprecated as well. This commit fixes these deprecations for this codebase. Refs: * https://wiki.php.net/rfc/deprecations_php_8_4#xml_set_object_and_xml_set_handler_with_string_method_names * https://www.php.net/manual/en/function.xml-set-object.php * https://www.php.net/manual/en/ref.xml.php
dd32
force-pushed
the
feature/php-8.4-fix-xml-set-handlers
branch
from
4e9fb3f
to
f80b99b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XML Parser extension still supports a quite dated mechanism for method based callbacks, where the object is first set via
xml_set_object()and the callbacks are then set by passing only the name of the method to the relevant parameters on any of thexml_set_*_handler()functions.Passing proper callables to the
xml_set_*_handler()functions has been supported for the longest time and is cross-version compatible. So the above code is 100% equivalent to:The mechanism of setting the callbacks with
xml_set_object()has now been deprecated as of PHP 8.4, in favour of passing proper callables to thexml_set_*_handler()functions. This is also means that calling thexml_set_object()function is deprecated as well.This commit fixes these deprecations for this codebase.
Refs: