-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce workflow that automatically closes pull requests #8139
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This is difficult to test, however I've tested pretty extensively in my fork. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
I think the GitHub link in the comment will need to use the full URL for the trac integration in order to show links. But let me test to be sure: If I am not confused by how the integration works, this should show up as https://core.trac.wordpress.org/ticket/62817#comment:4 |
const query = 'is:pr is:open repo:' + context.repo.owner + '/' + context.repo.repo + ' in:body https://core.trac.wordpress.org/ticket/' + ticket; | ||
const result = await github.rest.search.issuesAndPullRequests({ q: query }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever!
You mean the full link to the commit hash, not just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
Testing one other GH commit link format: |
@peterwilsoncc It looks like the comment did not make its way to Trac. I think that is likely due to the fact that we're ignoring comments from the GitHub Actions bot to avoid the playground and other comments from being posted on Trac tickets. I think this is probably fine, but wanted to make sure there are no strong feelings otherwise. |
I think that's preferable! Saves unnecessary noise on the ticket. |
This introduces a workflow that finds pull requests referencing any fixed tickets in commit messages.
Trac ticket: https://core.trac.wordpress.org/ticket/62817
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.