#62424 Populate the rest of the duplicated keys before populating the one that requires a translation

[johnbillion]

Trac ticket: https://core.trac.wordpress.org/ticket/62424

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props johnbillion, joemcgill, desrosj.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[joemcgill]

This seems to fix the reason I was seeing this behavior. I'm not sure whether anything would be expecting the $duplicated_keys order to be specific, but I didn't see any.

For readability, we may want to move both instances of 'put your unique phrase here' next to each other rather than splitting them by the foreach loop.

[desrosj]

Thanks for this. I think this is the best approach for 6.7.1 to fix this edge case.

I did some testing while using non-default locales, and the localized version of the string was also included in $duplicated_keys as expected.

[desrosj]

One other thing that I tested. I was wondering if the first recursive call of wp_salt() that occurred would not contain the localized version of the string. With a site localized into Japanese, this would be ここに独自のフレーズを入力します. In my testing, I was unable to confirm this to be the case. It seems like the localized version of the string will be in the array as expected with this PR.