Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests for default themes. #7484

Closed

Conversation

peterwilsoncc
Copy link
Contributor

@peterwilsoncc peterwilsoncc commented Oct 2, 2024

Additional tests for default themes:

  • Ensure test suite and WP_Theme default lists match
  • Ensure the constant matches the list in WP_Theme

I'd like to test the workflow file includes all of the themes but as not all systems include the yaml extension, I've left it out.

We could do a test via substr_count() but it seems pretty hacky.

Trac ticket: Core-61530


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Oct 2, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@peterwilsoncc peterwilsoncc force-pushed the fix/default-theme-tests branch from 3a13eb4 to 7e000f4 Compare October 3, 2024 00:06
@peterwilsoncc peterwilsoncc marked this pull request as ready for review October 3, 2024 00:08
Copy link

github-actions bot commented Oct 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props peterwilsoncc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@peterwilsoncc peterwilsoncc requested a review from desrosj October 3, 2024 00:08
@peterwilsoncc peterwilsoncc force-pushed the fix/default-theme-tests branch from 7e000f4 to bf8860d Compare October 7, 2024 00:14
@peterwilsoncc
Copy link
Contributor Author

r59186 / 023d3c4

@peterwilsoncc peterwilsoncc deleted the fix/default-theme-tests branch October 7, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant