Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of is_callable invocations in traverse_and_serialize_blocks #7387

Closed

Conversation

ryanwelcher
Copy link

This PR caches the is_callable calls in traverse_and_serialize_blocks rather than calling it for each iteration of the foreach loop. This should improve the performance of the function.

Trac ticket: https://core.trac.wordpress.org/ticket/62063


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Sep 17, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props welcher, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@ryanwelcher ryanwelcher changed the title Fix/performnance is callable Reduce number of is_callable invocations in traverse_and_serialize_blocks Sep 18, 2024
@mukeshpanchal27
Copy link
Member

I did some profiling and found that it reduce total call count for is_callable function and reduce wall time.

Before:
Screenshot 2024-09-18 at 4 27 20 PM

After:
Screenshot 2024-09-18 at 4 27 31 PM

FYI i test TT4 blog page.

@SergeyBiryukov
Copy link
Member

Thanks for the PR! Merged in r59077.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants