Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about empty templates in the frontend #7354

Closed

Conversation

vcanales
Copy link
Member

@vcanales vcanales commented Sep 14, 2024

Proposes adding a warning for logged-in users when navigating to a page or post rendered through an empty template. The warning explains why the website's visitors might encounter a blank page and points the logged-in user to the Site Editor to fix the template by resetting it or adding content to it.

Closes WordPress/gutenberg#64027.

Trac ticket: https://core.trac.wordpress.org/ticket/62053

Screenshot

image


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Sep 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props vcanales, mikachan, peterwilsoncc, richtabor, get_dave, mrfoxtalbot, matveb, arielmaidana, seifradwane, annezazu.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@mrfoxtalbot
Copy link

Thank you for working on this @vcanales, I added a comment with two minor suggestions WordPress/gutenberg#64027 (comment)

@mrfoxtalbot
Copy link

Can I ask you, @cbravobernal, or maybe @getdave to review this?
I'd love for this change to make it to the 6.7 in time.
Thanks a bunch.

Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few notes inline. Mainly to do with prefixing names with wp to avoid conflicts with existing themes and plugins.

I've put some product design notes on the ticket, so don't rush with any code changes while we figure out the best approach on the issue.

src/wp-includes/css/empty-template-alert.css Outdated Show resolved Hide resolved
src/wp-includes/script-loader.php Outdated Show resolved Hide resolved
src/wp-includes/script-loader.php Outdated Show resolved Hide resolved
src/wp-includes/block-template.php Outdated Show resolved Hide resolved
src/wp-includes/block-template.php Outdated Show resolved Hide resolved
src/wp-includes/block-template.php Outdated Show resolved Hide resolved
Copy link
Member

@richtabor richtabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback. Thanks!

@mikachan
Copy link
Member

Thanks for all the feedback, @richtabor 🙇 I think I've addressed all your comments, this is ready for another review.

Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sarah and I walked through this PR and it tested as expected.

Screenshot 2024-11-20 at 09 41 14

A couple of minor nits (one security related).

src/wp-includes/block-template.php Outdated Show resolved Hide resolved
src/wp-includes/block-template.php Outdated Show resolved Hide resolved
@getdave
Copy link
Contributor

getdave commented Nov 20, 2024

@mikachan Let me know when you are ready to commit this and we can pair on commit to WP Core.

Copy link
Member

@richtabor richtabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@getdave
Copy link
Contributor

getdave commented Nov 22, 2024

@mikachan This now needs a commit. A good opportunity for you. LMK if you want to run through this.

@mikachan
Copy link
Member

Committed to Core in core.trac.wordpress.org/changeset/59449.

@mikachan mikachan closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Site Editor: Provide Context and Direct Links to Fix Empty Templates
6 participants