-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn about empty templates in the frontend #7354
Warn about empty templates in the frontend #7354
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Thank you for working on this @vcanales, I added a comment with two minor suggestions WordPress/gutenberg#64027 (comment) |
Can I ask you, @cbravobernal, or maybe @getdave to review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few notes inline. Mainly to do with prefixing names with wp
to avoid conflicts with existing themes and plugins.
I've put some product design notes on the ticket, so don't rush with any code changes while we figure out the best approach on the issue.
Co-authored-by: Peter Wilson <[email protected]>
Co-authored-by: Peter Wilson <[email protected]>
Co-authored-by: Peter Wilson <[email protected]>
Co-authored-by: Peter Wilson <[email protected]>
Co-authored-by: Peter Wilson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some feedback. Thanks!
Thanks for all the feedback, @richtabor 🙇 I think I've addressed all your comments, this is ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Dave Smith <[email protected]>
Co-authored-by: Dave Smith <[email protected]>
@mikachan Let me know when you are ready to commit this and we can pair on commit to WP Core. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@mikachan This now needs a commit. A good opportunity for you. LMK if you want to run through this. |
Committed to Core in core.trac.wordpress.org/changeset/59449. |
Proposes adding a warning for logged-in users when navigating to a page or post rendered through an empty template. The warning explains why the website's visitors might encounter a blank page and points the logged-in user to the Site Editor to fix the template by resetting it or adding content to it.
Closes WordPress/gutenberg#64027.
Trac ticket: https://core.trac.wordpress.org/ticket/62053
Screenshot
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.