Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed schema for global styles REST API endpoint wp/v2/global-styles/{id} #7234

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from
+4 −5
Open

Fixed schema for global styles REST API endpoint wp/v2/global-styles/{id} #7234

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8243461
Fixed schema for global styles REST API endpoint
narenin Aug 23, 2024
f38572a
Corrected the ype of id
narenin Aug 25, 2024
06bb783
Merge branch 'trunk' into 61911-corrected-schema-global-style-endpoint
johnbillion Sep 17, 2024
5c487aa
Correct this description.
johnbillion Sep 17, 2024
1958b8b
Correct this type.
johnbillion Sep 17, 2024
fbcdf97
Implemented the suggestions/
narenin Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,17 +88,16 @@ public function register_routes() {
// Lists/updates a single global style variation based on the given id.
register_rest_route(
$this->namespace,
'/' . $this->rest_base . '/(?P<id>[\/\w-]+)',
'/' . $this->rest_base . '/(?P<id>[\/\d+]+)',
array(
array(
'methods' => WP_REST_Server::READABLE,
'callback' => array( $this, 'get_item' ),
'permission_callback' => array( $this, 'get_item_permissions_check' ),
'args' => array(
'id' => array(
'description' => __( 'The id of a template' ),
'type' => 'string',
'sanitize_callback' => array( $this, '_sanitize_global_styles_callback' ),
'description' => __( 'ID of global styles config.' ),
'type' => 'integer',
),
),
),
Expand Down Expand Up @@ -464,7 +463,7 @@ public function get_item_schema() {
'properties' => array(
'id' => array(
'description' => __( 'ID of global styles config.' ),
'type' => 'string',
'type' => 'integer',
'context' => array( 'embed', 'view', 'edit' ),
'readonly' => true,
),
Expand Down
Loading