-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
61436 wp get loading optimization attributes with src #6830
61436 wp get loading optimization attributes with src #6830
Conversation
… add_action() `error.message` LIKE 'Uncaught exception 'Error' with message 'Call to undefined function add_action()' in /var/www/wp-content/plugins/hello.php:69%' AND `error.class` = 'Error' AND transactionUiName = '/wp-content/plugins/hello.php' 'request_uri': '/wp-content/plugins/hello.php'
…dolly_uncaught_exception Fix Uncaught exception Error with message 'Call to undefined function…
…PATH direct access to wp-includes/rss.php on line 19 https://core.trac.wordpress.org/ticket/61277
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
…_attributes_with_src
PHP Test cases added
@deepakrohillas Left some suggestion other then it looks good to me. |
Co-authored-by: Mukesh Panchal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deepakrohillas Thank you for the PR! It looks great regarding the production code, though the test needs to be modified to properly cover the change.
I can apply that feedback inline.
Committed in https://core.trac.wordpress.org/changeset/58974 |
Trac ticket: https://core.trac.wordpress.org/ticket/61436