-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apostrophe fixes for 2015 theme #6823
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Thank you. For this ticket I think it's better to use the non-variable fonts to keep the fix as simple as possible. In the future, if there is a switch to variable fonts in older themes, they can be wrapped in I've pushed up the files in the Fontsouce zip on the ticket -- the files are now substantially smaller so it would be good to test they contain the expected glyphs |
The font stylesheet identifies 385 Unicode values for the Latin subset, and the newer Fontsource WOFF2 files are quite different. You could copy the tables I used to check them, but switch to the code editor view before pasting the HTML. Already with Twenty Fifteen 3.7, Firefox told me it used Times New Roman instead of Noto Serif for 63 of the 112 glyphs within the
Nine glyphs significantly changed the amount of space between them and other characters (including the
Additionally, the newer font has noticeably thicker line glyphs such as dashes, and the uppercase letters are shorter now. For comparison, I made images of 83 glyphs with some considerable changes from version 21 to version 23. |
https://core.trac.wordpress.org/ticket/59693
Apostrophe fixes for 2015 theme, including font files.
@karmatosed @sabernhardt I'm a little confused about which files from the zip are meant to be included, could you please clarify?
For now I've included the files from the Google Fonts zip but the file sizes are roughly double for each of the files which seems a lot.