Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apostrophe fixes for 2015 theme #6823

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

peterwilsoncc
Copy link
Contributor

https://core.trac.wordpress.org/ticket/59693

Apostrophe fixes for 2015 theme, including font files.

@karmatosed @sabernhardt I'm a little confused about which files from the zip are meant to be included, could you please clarify?

For now I've included the files from the Google Fonts zip but the file sizes are roughly double for each of the files which seems a lot.

Copy link

github-actions bot commented Jun 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props peterwilsoncc, sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@sabernhardt
Copy link

  • Google Fonts uses the variable font, and Fontsource did/does not, so that could easily explain the larger file size.
  • If we replace only the WOFF2 format, all of the woff?ver=23 updates would need to return to woff?ver=21. (The ticket has WOFF files, though I do not know their source.)

@peterwilsoncc
Copy link
Contributor Author

Thank you. For this ticket I think it's better to use the non-variable fonts to keep the fix as simple as possible.

In the future, if there is a switch to variable fonts in older themes, they can be wrapped in @supports queries to allow for fallbacks.

I've pushed up the files in the Fontsouce zip on the ticket -- the files are now substantially smaller so it would be good to test they contain the expected glyphs

@sabernhardt
Copy link

The font stylesheet identifies 385 Unicode values for the Latin subset, and the newer Fontsource WOFF2 files are quite different. You could copy the tables I used to check them, but switch to the code editor view before pasting the HTML.

Already with Twenty Fifteen 3.7, Firefox told me it used Times New Roman instead of Noto Serif for 63 of the 112 glyphs within the U+2000-206F range. The newer Fontsource files in the patch also fall back for three more glyphs:

  • 2191 Upwards Arrow
  • 2193 Downwards Arrow
  • 2215 Division Slash

Nine glyphs significantly changed the amount of space between them and other characters (including the U+02BC apostrophe) since the previous font version:

  • 0060 Grave Accent
  • 00A8 Diaeresis
  • 00B4 Acute Accent
  • 00B8 Cedilla
  • 02BB Modifier Letter Turned Comma
  • 02BC Modifier Letter Apostrophe
  • 02C6 Modifier Letter Circumflex Accent
  • 02DA Ring Above
  • 02DC Small Tilde

separation with version 21:
nine accents and related glyphs in older font version

separation with version 23:
in the newer font, the Modifier Letter Circumflex Accent glyph is closer to its surrounding letters, and the other eight glyphs have more space

Additionally, the newer font has noticeably thicker line glyphs such as dashes, and the uppercase letters are shorter now. For comparison, I made images of 83 glyphs with some considerable changes from version 21 to version 23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants