-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: wp_trim_words function to allow specific html tags #6798
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Hi @swissspidy can you please review this PR? |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Hi, thanks for the PR! I think we should consider passing What do you think? |
@audrasjb we can definitely do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. We also need a since
mention in the docblock :)
@mukeshpanchal27 @audrasjb any update for this PR? |
@swissspidy can you please review this PR? |
Why me specifically? 😅 I am on vacation |
@swissspidy Sorry for disturbing you. |
$text = wp_strip_all_tags( $text ); | ||
$num_words = (int) $num_words; | ||
if ( $allow_tags ) { | ||
$allowed_tags = array( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added all possible tags & styles to support excerpt styling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need some additional unit tests to ensure the code behaves as expected.
Instead of defining the allowed tags in this function, I recommend using an existing value from the existing kses functions. This will allow developers to modify the list of allowed tags according to their needs.
This will also need to ensure that the tags are balanced after the string has been trimmed to protect against HTML errors. See balanceTags()
Trac ticket:
https://core.trac.wordpress.org/ticket/59270
As
wp_strip_all_tags
function strips all HTML tags this won't allow doing any formatting to excerpt. I have usedwp_kses()
here with specific allowed HTML tags.Allowed tag list
Example output
Screen.Recording.2024-06-13.at.12.28.18.mov