Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attempt to read post ID on update_post_thumbnail_cache #6636

Closed
wants to merge 10 commits into from
Closed

Fix attempt to read post ID on update_post_thumbnail_cache #6636

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0b8fdf7
Fix attempt to read post ID on update_post_thumbnail_cache
itzmekhokan May 26, 2024
1960525
Update test cases
itzmekhokan May 27, 2024
134f2c7
Fix phpcs missing comma
itzmekhokan May 27, 2024
56c8eed
Fix suggested changes
itzmekhokan Jun 23, 2024
91d9de0
Addressed suggested changes for post thumbnail cache
itzmekhokan Oct 10, 2024
8000b0b
Improve comment and variable name.
peterwilsoncc Oct 13, 2024
7035e75
Split tests.
peterwilsoncc Oct 13, 2024
97a37d5
Merge branch 'trunk' into ticket/59521
peterwilsoncc Oct 13, 2024
729e7da
Test any call to prime posts contains the parent IDs.
peterwilsoncc Oct 13, 2024
40344ba
Merge branch 'trunk' into ticket/59521
peterwilsoncc Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/wp-includes/post-thumbnail-template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,17 @@
$thumb_ids = array();
peterwilsoncc marked this conversation as resolved.
Show resolved Hide resolved

foreach ( $wp_query->posts as $post ) {

/*
* Check $post is valid post object of WP_Post or not,
* while some cases it can be an array of $posts IDs.
*

Check failure on line 120 in src/wp-includes/post-thumbnail-template.php

View workflow job for this annotation

GitHub Actions / PHP coding standards / Run coding standards checks 

Whitespace found at end of line
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*
*

Fix PHPCS

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 fixed and updated test cases.

* See https://core.trac.wordpress.org/ticket/59521.
*/
if ( ! ( $post instanceof WP_Post ) ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ( ! ( $post instanceof WP_Post ) ) {
if ( ! $post instanceof WP_Post ) {

Nit-pick

$post = get_post( $post );
}

$id = get_post_thumbnail_id( $post->ID );
if ( $id ) {
$thumb_ids[] = $id;
Expand Down
Loading