Upgrade/Install: Make $is_debug consistent in WP_Automatic_Updater.

[costdev]

Trac ticket: https://core.trac.wordpress.org/ticket/58281

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props costdev, swissspidy.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[costdev]

@swissspidy I noticed that we had some inconsistencies in the debug guards and some of them checked WP_DEBUG_DISPLAY instead of WP_DEBUG_LOG.

Can you confirm that correcting the code to use WP_DEBUG && WP_DEBUG_LOG for all of the instances (which this PR does) will still prevent unexpected output in WP-CLI tests?

Thanks!

[swissspidy]

I think so, yes, When I check out this PR & run wp cron event run wp_version_check wp_update_plugins (which triggered these issues the last time) 👍

[SergeyBiryukov]

Thanks for the PR! Looks like this was merged in r58309.