Allow _embed to include all embedded objects #5758
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Co-authored-by: Mukesh Panchal <[email protected]>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @[email protected], @jonnynews. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: Timothy Jacobs <[email protected]>
|
Committed. |
| @@ -743,6 +743,13 @@ protected function embed_links( $data, $embed = true ) { | |||
| continue; | |||
| } | |||
|
|
|||
| if ( empty( $request['per_page'] ) ) { | |||
| $matched = $this->match_request_to_handler( $request ); | |||
There was a problem hiding this comment.
@spacedmonkey, this mutates the $request and sets the default context=view, which prevents the code below from setting it to an embed.
This is the cause of navigation fallback regression - https://core.trac.wordpress.org/ticket/43439#comment:17.
Follow on from #672
Trac ticket: https://core.trac.wordpress.org/ticket/43439
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.