Set autoload to 'no' for previously activated themes using upgrade routine #5711
Conversation
mukeshpanchal27
requested review from
westonruter,
joemcgill,
swissspidy and
felixarntz
|
@swissspidy i get |
|
No idea why this happens just for this PR 🤷 |
|
Seems confirmed that the Performance Test is failing due to this change for some reason as other, more recent runs, are not effected. See: https://github.com/WordPress/wordpress-develop/actions/workflows/performance.yml?query= We need to debug this before committing in order to not introduce failures into trunk. |
There was a problem hiding this comment.
Thank you for the PR @mukeshpanchal27. It mostly looks good, but there is one crucial thing missing I believe.
|
The Performance tests going fails if we update DB version. Check PR: #5716 not sure but seems there is bug Performance tests setup. |
|
Oooh I know what's up! Because of the version bump and the following checkout of the previous commit, WordPress is showing the "Database upgrade required" screen, so you first have to run the db upgrade. I tested this hypothesis in #5717, where you can see that tests now pass :) |
|
Great @swissspidy, it's fascinating how we can encounter unforeseen issues while focusing on different tasks. I suggest we commit that PR initially without altering the DB version. Afterward, we can rebase this PR, making it ready for the final commit. |
|
Performance tests ✅ |
|
Committed in https://core.trac.wordpress.org/changeset/57155 |
Trac ticket: https://core.trac.wordpress.org/ticket/59975
This PR add upgrade routine for 6.5 that set autoload to 'no' for previously activated themes.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.