added test for send_frame_options_header #5638
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
reviewed
Feb 27, 2024
swissspidy
reviewed
Feb 27, 2024
swissspidy
reviewed
Feb 27, 2024
Co-authored-by: Pascal Birchler <[email protected]>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: Pascal Birchler <[email protected]>
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The unit test for send_frame_options_header function is updated to manage PHP Warnings and check response headers. setUp and tearDown methods are added to manage error levels, and the test_send_frame_options_header method now checks the 'X-Frame-Options' in the response headers. Also, this update necessitated the inclusion of xdebug as part of the test suite.
The unit test for send_frame_options_header function is updated to manage PHP Warnings and check response headers. setUp and tearDown methods are added to manage error levels, and the test_send_frame_options_header method now checks the 'X-Frame-Options' in the response headers. Also, this update necessitated the inclusion of xdebug as part of the test suite.
Two superfluous line breaks were removed from the PHPUnit test for sendFrameOptionsHeader function to improve code readability. This refactoring does not alter the functionality or performance of the test suite.
This patch adjusts the formatting of the assertStringContainsString statement in the PHPUnit test for the sendFrameOptionsHeader function. It simply removes an extra space without making substantial changes to the code or its functionality.
This patch adjusts the formatting of the assertStringContainsString statement in the PHPUnit test for the sendFrameOptionsHeader function. It simply removes an extra space without making substantial changes to the code or its functionality.
The debug statement (`var_dump( $headers );`) was removed from the sendFrameOptionsHeader PHPUnit test. This modification makes the test output cleaner and more focused on asserting the expected conditions.
The line setting the error level was removed from the sendFrameOptionsHeader PHPUnit test. This tweak simplifies the test setup and helps to reduce the side effects associated with modifying the global error reporting level.
The set_up method in sendFrameOptionsHeader test was modified to get rid of the error suppression line. This change helps decrease the overall complexity of the test setup. Moreover, it minimizes potential negative impacts related to altering the global error reporting level.
swissspidy
reviewed
Mar 3, 2024
swissspidy
reviewed
Mar 3, 2024
Co-authored-by: Pascal Birchler <[email protected]>
remove not needed test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/59851